Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@subhankar-ghosh
Copy link
Collaborator

@subhankar-ghosh subhankar-ghosh commented Apr 21, 2022

Signed-off-by: Subhankar Ghosh [email protected]

What does this PR do ?

Removes the requirement of 'max_token_duration', 'min_token_duration' and 'zero_emb' to be restored from the state_dict. This PR sets persistent=False in register_buffer for the above variables.
This PR also sets the correct URL to download the latest Fastpitch checkpoint.

Collection: [Note which collection this PR will affect]

  1. nemo.collection.tts.models
  2. nemo.collection.tts.modules

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@subhankar-ghosh subhankar-ghosh changed the title restore_buffer bug fix and update NeMo checkpoint URL [TTS] Restore_buffer bug fix and update NeMo checkpoint URL Apr 21, 2022
borisfom
borisfom previously approved these changes Apr 21, 2022
Signed-off-by: ericharper <[email protected]>
@ericharper ericharper merged commit 2ef2892 into r1.8.1 Apr 22, 2022
@ericharper ericharper deleted the fastpitch_fix branch April 22, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants