Codestin Search App

lukeyeager · 2016-09-19T21:58:13Z

Close #941, close #180, fix #1090
Bug 1804528

Env vars are easy to change between deploys without changing any code; unlike config files, there is little chance of them being checked into the code repo accidentally; and unlike custom config files, or other config mechanisms such as Java System Properties, they are a language- and OS-agnostic standard.
https://12factor.net/config

Also,

Once we add a working setup.py, multiple users will be able to start their own customized instance from the same installed codebase (instance-specific config capability needed #941)
The ability to set the configuration interactively doesn't scale well as we continue to add options

gheinrich · 2016-09-20T12:50:09Z

This seems to improve the time it takes to start tools (and this should be reflected on Travis test time too):

before:

$ time ./tools/inference.py --help
real    0m0.821s

After:

$ time ./tools/inference.py --help
real    0m0.438s

gheinrich

Can we document the full list of environment variables?

gheinrich · 2016-09-20T12:57:59Z

digits/config/extension_list.py

-    @classmethod
-    def get_extensions(cls, show_all):
-        return extensions.view.get_extensions(show_all=show_all)
+if 'DIGITS_ALL_EXTENSIONS' in os.environ:


nice simplification!

gheinrich · 2016-09-20T13:00:21Z

digits/config/jobs_dir.py

-            # make the directory
-            os.mkdir(self._config_file_value)
+
+if 'DIGITS_MODE_TEST' in os.environ:


maybe move this to a function like you are doing for other options like log_file?

Do you really think that's more legible? I thought I'd just keep it simple when I can.

No I think it's fine this way, forget that comment.

gheinrich · 2016-09-20T13:06:54Z

digits/frameworks/caffe_framework.py

-    if config_value('caffe_root')['flavor'] == 'NVIDIA':
-        if config_value('caffe_root')['version'] > parse_version('0.14.0-alpha'):
+    if config_value('caffe')['flavor'] == 'NVIDIA':
+        if parse_version(config_value('caffe')['version']) > parse_version('0.14.0-alpha'):


tested this path - ok

gheinrich · 2016-09-20T13:07:23Z

digits/config/caffe.py

+
+
+if 'CAFFE_ROOT' in os.environ:
+    executable, version, flavor = load_from_envvar('CAFFE_ROOT')


tested this path - OK

gheinrich · 2016-09-20T13:07:44Z

digits/config/torch.py

+        raise ValueError('Torch executable not found at "%s" (TORCH_HOME)'
+                         % os.environ['TORCH_HOME'])
+else:
+    executable = find_executable()


tested this path - OK

lukeyeager · 2016-09-20T17:40:26Z

Can we document the full list of environment variables?

I added a doc at docs/Configuration.md.

gheinrich

Maybe edit the doc in https://github.com/NVIDIA/DIGITS/blob/v4.0.0/docs/BuildDigits.md#building-digits too?

lukeyeager · 2016-09-21T16:50:04Z

Thanks for the review Greg! I'm going to merge this now, to enable #1093 (which enables #927).

lukeyeager · 2016-09-21T17:10:56Z

Oops, I meant to squash before merging. Sorry.

Use envvars for configuration instead of a file

lukeyeager added the enhancement label Sep 19, 2016

Use envvars for config instead of a file

b1c2f1c

lukeyeager force-pushed the envvars branch from dd8f539 to b1c2f1c Compare September 19, 2016 22:00

gheinrich suggested changes Sep 20, 2016

View reviewed changes

lukeyeager added 2 commits September 20, 2016 10:13

_HOME -> _ROOT

800e352

Added configuration doc

e615f4e

gheinrich reviewed Sep 20, 2016

View reviewed changes

gheinrich approved these changes Sep 20, 2016

View reviewed changes

lukeyeager mentioned this pull request Sep 20, 2016

Add a setup.py script #1093

Merged

5 tasks

lukeyeager merged commit 3afc367 into NVIDIA:master Sep 21, 2016

lukeyeager deleted the envvars branch September 21, 2016 16:50

gheinrich mentioned this pull request Sep 22, 2016

A valid Caffe installation was not found on your system. Use the envvar CAFFE_ROOT to indicate a valid installation. #1107

Closed

This was referenced Sep 26, 2016

Update docs for v4.1 #1123

Merged

Stop deleting logfiles #1126

Merged

Bugfix - Torch and CUDA_VISIBLE_DEVICES #1130

Merged

lukeyeager mentioned this pull request Oct 20, 2016

No jobs showing in Digits Home #831

Open

lukeyeager mentioned this pull request Oct 27, 2016

How Can I set Caffe CPU mode while installing the Ubuntu Pre-built package. #1182

Closed

lukeyeager mentioned this pull request Nov 18, 2016

Error when using multi-gpu #1269

Closed

lukeyeager mentioned this pull request Jan 24, 2017

Installing two DIGITS on one computer #1411

Open

lukeyeager mentioned this pull request Mar 29, 2017

Configuration Issues with Digits 5.0 on Ubuntu 16.04 #1545

Closed

SlipknotTN pushed a commit to cynnyx/DIGITS that referenced this pull request Mar 30, 2017

Merge pull request NVIDIA#1091 from lukeyeager/envvars

bf0aa9c

Use envvars for configuration instead of a file

lukeyeager mentioned this pull request Aug 7, 2017

Error for '--config' argument #1754

Closed



		if 'CAFFE_ROOT' in os.environ:
		executable, version, flavor = load_from_envvar('CAFFE_ROOT')

Conversation

lukeyeager commented Sep 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gheinrich commented Sep 20, 2016

Uh oh!

gheinrich left a comment

Choose a reason for hiding this comment

Uh oh!

gheinrich Sep 20, 2016

Choose a reason for hiding this comment

Uh oh!

gheinrich Sep 20, 2016

Choose a reason for hiding this comment

Uh oh!

lukeyeager Sep 20, 2016

Choose a reason for hiding this comment

Uh oh!

gheinrich Sep 20, 2016

Choose a reason for hiding this comment

Uh oh!

gheinrich Sep 20, 2016

Choose a reason for hiding this comment

Uh oh!

gheinrich Sep 20, 2016

Choose a reason for hiding this comment

Uh oh!

gheinrich Sep 20, 2016

Choose a reason for hiding this comment

Uh oh!

lukeyeager commented Sep 20, 2016

Uh oh!

gheinrich left a comment

Choose a reason for hiding this comment

Uh oh!

lukeyeager commented Sep 21, 2016

Uh oh!

lukeyeager commented Sep 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lukeyeager commented Sep 19, 2016 •

edited

Loading