Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated notebook documentation and refactored some code #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

Updated notebook documentation and refactored some code #398

merged 1 commit into from
Mar 28, 2023

Conversation

@cliffburdick
Copy link
Collaborator

@cliffburdick cliffburdick commented Mar 27, 2023 •
edited
Loading

Closes #396

@tylera-nvidia
Copy link
Collaborator

tylera-nvidia commented Mar 27, 2023 •
edited
Loading

In several of the examples we have commented out code, do we want to keep that around or should we uncomment it? I don't quiet understand why we comment some of the test code out, and leave others in.

Example here
or here

@cliffburdick
Copy link
Collaborator Author

cliffburdick commented Mar 27, 2023

In several of the examples we have commented out code, do we want to keep that around or should we uncomment it? I don't quiet understand why we comment some of the test code out, and leave others in.

it's commented out because it's part of an example they are supposed to fill out for the training

tylera-nvidia
tylera-nvidia approved these changes Mar 27, 2023
View reviewed changes
@cliffburdick cliffburdick merged commit ece73fc into main Mar 28, 2023
@cliffburdick cliffburdick deleted the notebook_update branch March 28, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylera-nvidia tylera-nvidia tylera-nvidia approved these changes

@luitjens luitjens Awaiting requested review from luitjens

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Clean up notebooks

3 participants

@cliffburdick @tylera-nvidia