implement *batched* tri-diagonal direct solve #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request implements support for batched tri‐diagonal direct solves in the library. Key changes include:
- Updating the single tri‐diagonal solver interface to use a dedicated output parameter.
- Adding a new function (SolveBatchedTridiagonalSystem) to support batched tri‐diagonal solves.
- Updating sparse tensor format definitions and factory functions to support uniform batched DIA formats.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| include/matx/transforms/solve/solve_cusparse.h | Updated single solver interface and added batched solver API |
| include/matx/core/sparse_tensor_format.h | Modified format checks for DIA and added batched DIA uniform support |
| include/matx/core/make_sparse_tensor.h | Added factory method for uniform batched DIA tensor creation |
| examples/sparse_tensor.cu | Provided an example for batched direct solve implementation |
| docs_input/basics/sparse_tensor.rst | Updated documentation to reflect batched tri‐diagonal support |
Comments suppressed due to low confidence (2)
include/matx/transforms/solve/solve_cusparse.h:54
- [nitpick] Consider renaming the parameter 'x' to something more descriptive (e.g. 'rhs' or 'out') to clarify its role as the solution output.
VAL *x) {
include/matx/transforms/solve/solve_cusparse.h:101
- [nitpick] Consider renaming the parameter 'b' (which represents the batch count) to 'batch' for improved readability and to avoid potential confusion with the right-hand side pointer.
VAL *du, VAL *x) {
|
/build |
Co-authored-by: Cliff Burdick <[email protected]>
|
/build |
1 similar comment
|
/build |
cliffburdick
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.