[libcu++] Add explicit alignment specification in buffer #7005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
approved these changes
Dec 17, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
approved these changes
Dec 19, 2025
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 12h 27m: Pass: 100%/91 | Total: 1d 01h | Max: 1h 24m | Hits: 96%/217741See results here. |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin branch/3.2.x
git worktree add -d .worktree/backport-7005-to-branch/3.2.x origin/branch/3.2.x
cd .worktree/backport-7005-to-branch/3.2.x
git switch --create backport-7005-to-branch/3.2.x
git cherry-pick -x 7e6770d30df6b917ee213a9889ab0fafa426ecef |
pciolkosz
added a commit
to pciolkosz/cccl
that referenced
this pull request
Dec 19, 2025
* Add explicit alignment specification in buffer * Fix shared resource test * Missed alignment in deallocate (cherry picked from commit 7e6770d)
fbusato
pushed a commit
to fbusato/cccl
that referenced
this pull request
Dec 23, 2025
* Add explicit alignment specification in buffer * Fix shared resource test * Missed alignment in deallocate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should explicitly pass alignment of the stored type into
allocateinstead of relying on the default.We currently have no way to specify a different alignment requirement, but a future change will add it