Explicitly set CCCL_TOPLEVEL_PROJECT to OFF when needed
#7016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions use the value of `${CCCL_TOPLEVEL_PROJECT}`, and when
it's not set, that causes such functions to misparse their arguments.
Explicitly set it to `OFF` in such cases.
robertmaynard
approved these changes
Dec 18, 2025
Contributor
|
/ok to test 36e7346 |
auto-merge was automatically disabled
December 18, 2025 17:49
Head branch was pushed to by a user without write access
Member
Author
|
/ok to test c8328f3 |
Contributor
😬 CI Workflow Results🟥 Finished in 2h 26m: Pass: 91%/270 | Total: 3d 11h | Max: 1h 25m | Hits: 99%/359761See results here. |
Contributor
|
/ok to test a0b4ffe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some functions use the value of
${CCCL_TOPLEVEL_PROJECT}, and when it's not set, that causes such functions to misparse their arguments. Explicitly set it toOFFin such cases while preserving the ability to override it manually.First time this got lost: 365fa2b#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL9-L10
Second time this got lost: https://github.com/NVIDIA/cccl/pull/6722/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL12
Checklist