This repository was archived by the owner on Mar 21, 2024. It is now read-only.
In-place guarantees for scan algorithms #490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple issues of in-place execution for scan algorithms:
Scan:
LOAD_LDGis removed from tuning policies to guarantee in-place execution. Affected architectures are Kepler and Maxwell. Benchmarks showed no difference in performance on those platforms.decltype(*d_in)withOutputTwhich always led to comparingT&withT. Therefore, we've never tested in-place execution.Scan by key:
LOAD_LDGis removed from tuning policies to guarantee in-place execution.decltype(*d_values_in)withOutputTwhich always led to comparingT&withT. Therefore, we've never tested in-place execution.