Specify flit build-system within pyproject.toml
#1317
Conversation
|
I suspect this is not how we want to expose packages for this project. The library usage pattern interface is still being worked out however most sub-packages for Note the Note the project currently uses @06kellyjac, I noticed a number of PRs this week that seem to be targeting a goal. If you would like to reach out on discord, we can coordinate on how to get the right context shared and smooth out the feedback loop. |
|
Ah, it's handy to know you're using Yeah joining the discord is a good idea, thanks :) I'll find the link |
With the team using flit to build and package garak it can be defined in the pyproject.toml rather than with setuptools.
1f98cbf to
5953432
Compare
flit build-system within pyproject.toml
|
How does this impact consumption of |
|
Well with So I'm not sure it was working correctly for a while now. For filt IDK if it even needs a |
Several items in MANIFEST.in were triggering `warning: manifest_maker: MANIFEST.in, line 1: unknown action` warnings With flint the convention for additional resources is to use `[tool.flit.sdist]` or `[tool.flit.external-data]` https://flit.pypa.io/en/stable/pyproject_toml.html#external-data-section
|
searching my result built with flit I did a diff with before (setuptools + manifest) and after (flit and this PR) and had no difference I'd note the following files I'd probably expect to be there based on ( |
|
pip install test seems to have passed which is promising |
Shifted PR to specify filt build system as used by the team.
Old PR Message
Addresses the following warning when building:
Package would be ignored
Python recognizes 'garak.probes' as an importable package(1),
but it is absent from setuptools'
packagesconfiguration.This leads to an ambiguous overall configuration. If you want to distribute this
package, please make sure that 'garak.probes' is explicitly added
to the
packagesconfiguration field.Alternatively, you can also rely on setuptools' discovery methods
(for example by using
find_namespace_packages(...)/find_namespace:instead of
find_packages(...)/find:).You can read more about "package discovery" on setuptools documentation page:
If you don't want 'garak.probes' to be distributed and are
already explicitly excluding 'garak.probes' via
find_namespace_packages(...)/find_namespaceorfind_packages(...)/find,you can try to use
exclude_package_data, orinclude-package-data=Falseincombination with a more fine grained
package-dataconfiguration.You can read more about "package data files" on setuptools documentation page:
1: For Python, any directory (with suitable naming) can be imported,
even if it does not contain any
.pyfiles.On the other hand, currently there is no concept of package data
directory, all directories are treated like packages.
garak.probesis explicitly referenced in the README.md so should be properly included.If some packages should be excluded LMK.