Internal names refinement #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Patrin <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors internal naming and function signatures related to factory registration, spawning, and closing.
- Changes include removing the context parameter from registerFactory
- Renaming produceServices/closeServices to spawnFactories/closeFactories in both production and test code
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| registry_test.go | Updated tests to call registerFactory without a context and use new names. |
| registry.go | Refactored registerFactory, spawnFactories, and closeFactories function names. |
| factory_test.go | Revised factory.load tests to remove external context checks. |
| factory.go | Adjusted load method to create a cancellable context internally. |
| container.go | Updated registration and lifecycle method calls to align with the refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal names refinement.