Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@karthikvetrivel
Copy link
Member

@karthikvetrivel karthikvetrivel commented Oct 21, 2025

The cherrypick GitHub Action was running unconditionally on every PR merge. I initially thought this was fine but it caused unnecessary workflow runs and also led to failures. Failures are the bigger issue of the two.

Allow Cherry-Pick Bot to Backport PRs From Just Comments

Now, we can create backports at any point in the review process by using the /cherry-pick comment. This prevents running the GHA workflow on every merge and instead only when a user comments /cherry-pick

Changes

  • Remove pull_request_target trigger, use only /cherry-pick comments
  • Remove merge validation to support backporting open PRs
  • Add merge status warnings in backport PR descriptions
  • Skip gracefully instead of failing when no branches specified

Use Case

Run /cherry-pick release-v1.0 on an open PR to create a backport early. The bot warns if the source PR isn't merged yet.

@karthikvetrivel karthikvetrivel marked this pull request as draft October 22, 2025 03:38
@karthikvetrivel karthikvetrivel force-pushed the ci/integrate-cherry-pick-bot branch from 41d456c to 154e246 Compare October 22, 2025 12:34
@karthikvetrivel karthikvetrivel marked this pull request as ready for review October 22, 2025 12:45
@elezar
Copy link
Member

elezar commented Oct 22, 2025

Question: Does the bot update / recreate a PR if a user issues another comment?

@karthikvetrivel
Copy link
Member Author

@elezar Not currently. We could have the bot use git push --force-with-lease and update the PR manually?

@karthikvetrivel karthikvetrivel force-pushed the ci/integrate-cherry-pick-bot branch from 154e246 to 1a2440c Compare October 22, 2025 12:59
@karthikvetrivel
Copy link
Member Author

@elezar I just added support for PR updates. The bot now detects and updates existing backport PRs when users re-run /cherry-pick commands, using force-push to sync changes and updating PR descriptions with current conflict/merge status. We can now iteratively change backports w/o manual cleanup.

@karthikvetrivel karthikvetrivel changed the title fix: allow workflow to run with no branches identified fix: allow workflow to run with no branches identified + support PR updates Oct 22, 2025
@karthikvetrivel karthikvetrivel force-pushed the ci/integrate-cherry-pick-bot branch from cb5b622 to 1a2440c Compare October 22, 2025 13:09
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get this in and iterate!

@karthikvetrivel karthikvetrivel force-pushed the ci/integrate-cherry-pick-bot branch from 1a2440c to 6e1494a Compare October 22, 2025 13:29
@karthikvetrivel karthikvetrivel force-pushed the ci/integrate-cherry-pick-bot branch from 6e1494a to 316284b Compare October 22, 2025 13:49
@elezar elezar disabled auto-merge October 22, 2025 13:52
@elezar elezar merged commit 6f3d599 into NVIDIA:main Oct 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants