-
Notifications
You must be signed in to change notification settings - Fork 442
fix: allow workflow to run with no branches identified + support PR updates #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow workflow to run with no branches identified + support PR updates #1812
Conversation
d94c037 to
381ee2e
Compare
41d456c to
154e246
Compare
|
Question: Does the bot update / recreate a PR if a user issues another comment? |
|
@elezar Not currently. We could have the bot use |
154e246 to
1a2440c
Compare
|
@elezar I just added support for PR updates. The bot now detects and updates existing backport PRs when users re-run /cherry-pick commands, using force-push to sync changes and updating PR descriptions with current conflict/merge status. We can now iteratively change backports w/o manual cleanup. |
cb5b622 to
1a2440c
Compare
elezar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's get this in and iterate!
1a2440c to
6e1494a
Compare
…riggers Signed-off-by: Karthik Vetrivel <[email protected]>
6e1494a to
316284b
Compare
The cherrypick GitHub Action was running unconditionally on every PR merge. I initially thought this was fine but it caused unnecessary workflow runs and also led to failures. Failures are the bigger issue of the two.
Allow Cherry-Pick Bot to Backport PRs From Just Comments
Now, we can create backports at any point in the review process by using the
/cherry-pickcomment. This prevents running the GHA workflow on every merge and instead only when a user comments/cherry-pickChanges
pull_request_targettrigger, use only/cherry-pickcommentsUse Case
Run
/cherry-pick release-v1.0on an open PR to create a backport early. The bot warns if the source PR isn't merged yet.