Add instructions for building in a container #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds instructions for building nvkind in a container as an alternative to setting up a local Go build environment.
- Added a section in README.md detailing how to run the build inside a Go container
- Provided a Docker run command example to build nvkind without a local Go installation
Collaborator
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Hey @jacobtomlinson thanks for your contribution! please sign your commit so it passes the DCO verification, thank you
Signed-off-by: Jacob Tomlinson <[email protected]>
8ad3503 to
17e3345
Compare
Member
Author
|
Oh yep sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I installed
nvkindon a system that didn't havego. It felt easier to do the build in a container than set up a go build environment.Adding instructions here in case it's useful for someone else.