Upgrade Docker baseimage to Python 3.12#805
Merged
juhoinkinen merged 1 commit intomainfrom Sep 30, 2024
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
========================================
Coverage 99.65% 99.65%
========================================
Files 93 93
Lines 6939 7058 +119
========================================
+ Hits 6915 7034 +119
Misses 24 24 ☔ View full report in Codecov by Sentry. |
osma
approved these changes
Sep 30, 2024
Member
osma
left a comment
There was a problem hiding this comment.
LGTM. We need to test if old models can still be loaded after this.
Member
Author
|
I checked the projects at ai.dev.finto.fi, and other projects than those using NN ensemble seem to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now when Python 3.12 will be fully supported (after #796), lets upgrade to it in Docker image.
The upgrade should bring some performance improvements.