Update RMMatureCreatureRobotController.m #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS11 or upper, additional permission alert is necessary to access PhotoLibrary.
fotiDim
approved these changes
Mar 14, 2021
Contributor
fotiDim
left a comment
There was a problem hiding this comment.
Konnichiwa! Thanks for the PR!
The Privacy - Photo Library Usage Description is only used prior to 11 when opening the UIImagePickerController. It is normal that you don't see it in iOS 14.
I will do some improvements to photo permission handling after this get merged. We can centralize the permission code, remove deprecated APIs and also benefit Romo Control which I believe has the same issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I found an issue on iOS14.4.
The Romo app cannot save a photo into PhotoLibrary.
On iOS11 or upper, additional permission alert is necessary to access PhotoLibrary.
I added a quick fix, and check it on iOS14.4.
I haven't get the alert message from text resource yet...Sorry...
Thanks.