feat: add pause/unpause and set-state action cards for occupancy control #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements manual control of occupancy state via Home Automation flows. ## Features - SET STATE action: Pauses device and sets occupancy to OCCUPIED or UNOCCUPIED - UNPAUSE action: Resumes sensor monitoring with automatic reinitialization - IS PAUSED condition: Check if device is in paused mode for flow logic - Quad-state occupancy model: Extends internal state with PAUSED value - Idempotent unpause: Multiple unpause calls only reinitialize once - Comprehensive logging: All pause/unpause operations logged for debugging ## Implementation Details - Added OccupancyState.PAUSED enum value for internal state tracking - Pause gates in sensor event handlers prevent state changes while paused - Flow card definitions in driver.flow.compose.json properly located for Homey CLI - Occupancy_state capability extended to support PAUSED value - 10 new unit tests covering all pause/unpause scenarios - All 74 tests pass with >70% code coverage ## Use Cases - Users can pause monitoring during sleep to prevent false positives from pets - Manually set occupancy for specific testing scenarios - Combine with automations for advanced occupancy control Closes #5
ea8d6f2 to
05b1bed
Compare
The Homey CLI build process requires app.json to exist before running. Added back the cp command to copy from .homeycompose/app.json before building, which was accidentally removed during commit cleanup.
…ality ## Fixes ### Critical Error Handling Issues - Register flow card handlers with proper validation and re-throw errors - Propagate errors from pauseDevice() and unpauseDevice() to flow engine - Add null checks for getActionCard() and getConditionCard() results - Improve error context in updateOccupancyOutput() with specific capability names - Re-throw errors in action/condition handler listeners to notify flow engine ### Code Quality - Remove unused setStateWhilePaused() dead code method - Remove unused hasBeenUnpausedOnce variable - Update class docstring: tri-state → quad-state model - Add comprehensive manual control documentation ### Test Coverage - Add test for door events ignored while paused - Add test for PIR falling edge ignored while paused - Add test for sensor monitoring teardown on pause - Add test for unpause with graceful error handling - Now at 78 tests covering all pause/unpause scenarios All tests pass, build succeeds, linting clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
- Add flow object mock to createMockHomey() in tests/setup.ts with action/condition card support - Provides getActionCard() and getConditionCard() methods for action/condition registration - Fixes "Cannot read properties of undefined (reading 'getActionCard')" errors in CI - Fix error handling tests for fire-and-forget async callbacks - Use mockRejectedValueOnce() to isolate error test from other tests - Increase wait time in test to allow async handlers to complete - Properly verify error logging from handlers This resolves all CI test failures while maintaining test coverage and error handling validation.
This was referenced Dec 20, 2025
NdyGen
pushed a commit
that referenced
this pull request
Dec 24, 2025
…ange BREAKING CHANGE: WarningManager.setWarning() and clearWarning() now throw WarningStateError instead of returning boolean. All call sites updated. Core Changes: - WarningManager API: Promise<boolean> → Promise<void> (throws on failure) - Created WarningStateError custom error class with operation context - Added AsyncHelpers utility for standardized fire-and-forget async operations - Added CapabilityErrorTracker for aggregated capability error reporting - Extended RetryResult<T> interface with error classification fields Error Handling Improvements: - 13 call sites migrated to try-catch pattern (9 room-state, 4 zone-seal) - RetryManager now exposes isPermanentError, errorCategory, errorReasonCode - Enhanced app.ts logging with permanent error context detection - Added WARNING_SET_FAILED and WARNING_CLEAR_FAILED error IDs Testing: - Added 36 new tests (AsyncHelpers: 18, CapabilityErrorTracker: 18) - Total tests: 503 (all passing) - Coverage: AsyncHelpers 100%, CapabilityErrorTracker 98.21% - All quality gates pass (build, lint, test, validate) Addresses PR review issues #2, #3, #5 from comprehensive code review. Issues #1, #4, #6, #7 deferred for follow-up PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements action cards and condition cards for manual control of the WIAB device's occupancy state, addressing issue #5. This feature enables users to pause/unpause sensor monitoring and manually set occupancy state through Home Automation flows.
Key Features:
Use Case:
Users can now set their bedroom occupancy to "unoccupied" at night, preventing false positives from pet movement, then resume normal monitoring in the morning.
Technical Details:
OccupancyState.PAUSEDenum value for internal state trackingTest Plan:
Closes #5