Additional key / ref constraints #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove previously added ClassInFrame constraints
skinkie
reviewed
Oct 26, 2025
Equipment complete family
skinkie
reviewed
Oct 27, 2025
Contributor
|
@trurlurl thanks for the massive effort. |
skinkie
approved these changes
Oct 27, 2025
ue71603
approved these changes
Oct 28, 2025
Collaborator
thbar
approved these changes
Oct 30, 2025
Collaborator
thbar
left a comment
There was a problem hiding this comment.
@trurlurl great work, thank you!
Here are my notes & questions (not merge-blocking):
- Overall I understand the addition of
unique/key/keyrefto provide more structural integrity. This will most likely break existing XML files (no matter the country), but overall this will happen more in upcoming releases and is a good thing IMO. Equipmentincludes a list of targets (via XPath): we will need to ensure newly added equipments are added here, and we will probably need an automated way to warn about incomplete lists like this one.- ❔ I spotted 5 items for which I couldn't find the formal definition:
Facility,ParkingEntrance,PlaceLightingEquipment,VehicleEquipmentandWheelchairVehicle(not the ref, the item itself). Are these defined somewhere? (the correspondingRefare defined, though)
Merging is OK IMO (thanks again!), but I'm interested in some clarifications from anyone who may have them 😄
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #972. The below list has been added in NeTEx_publication.xsd.
#972 started the discussion for which classes to add constraints - we can adapt this PR based on the further discussion.
I added everything to NeTEx_publication.xsd - please tell me if something should be moved to NeTEx_publication_timetable.xsd or how to determine the right place.