Issue #81 - On starting a timer mark TP task as "In Progress", if current task state is "Open" or "Dev ready" #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenPattison
suggested changes
Feb 11, 2021
src/commands/start.ts
Outdated
Comment on lines
25
to
28
| // Issue #81: If the linked TP entity is a Task *and* its current state is 'Open' or 'Dev ready', set the task to 'In Progress' | ||
| // Note: It is important to verify current state of Task, otherwise if a 'Done' task with time remaining is moved to 'In Progress', | ||
| // it may increase the time on a story / feature which the dev / user might not realize as the task has moved to 'In Progress' by this utility | ||
| // And if the time remaining has not reached 0, the task might not move to 'Done' when the timer is finished |
There was a problem hiding this comment.
I think this flags the need for a wiki on this package given it is OSS, we should have things like this documented for visibility we can then reference documentation in the code if it is really necessary - for this case just documenting it should be enough I believe, then we can remove the comments.
There was a problem hiding this comment.
OwenPattison
suggested changes
Feb 24, 2021
src/commands/start.ts
Outdated
| try { | ||
| await harvestApi.startTimeEntry(details.projectId, details.taskId, date, notes, details.hours, details.running); | ||
|
|
||
| // Issue #81: If the linked TP entity is a Task *and* its current state is 'Open' or 'Dev ready', set the task to 'In Progress' |
There was a problem hiding this comment.
we can remove this comment too as the issue will have a reference to this pr
OwenPattison
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81