Thanks to visit codestin.com
Credit goes to github.com

Skip to content

afpd: afpstats init error handling; don't build on macOS #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2025
Merged

afpd: afpstats init error handling; don't build on macOS #2448

merged 3 commits into from
Nov 2, 2025

Conversation

@rdmark
Copy link
Member

@rdmark rdmark commented Oct 2, 2025 •
edited
Loading

A set of minor changes to afpstats for better logging, error checking during startup, while not building on macOS with warning message

@rdmark rdmark linked an issue Oct 2, 2025 that may be closed by this pull request
crash on macOS when client connects to server with afpstats enabled #2358
Closed
@rdmark rdmark force-pushed the 2358-crash-on-macos-when-client-connects-to-server-with-afpstats-enabled branch from 04c0280 to 79edf72 Compare October 2, 2025 20:24
@rdmark rdmark force-pushed the 2358-crash-on-macos-when-client-connects-to-server-with-afpstats-enabled branch 4 times, most recently from a558ef8 to 2a909b4 Compare October 26, 2025 08:52
@rdmark rdmark changed the title afpd: clean up afpstats thread when exiting or erroring out afpd: comprehensive handling of the afpstats D-Bus thread lifecycle Oct 26, 2025
@rdmark rdmark force-pushed the 2358-crash-on-macos-when-client-connects-to-server-with-afpstats-enabled branch 2 times, most recently from 4ba3b32 to e684682 Compare October 26, 2025 09:39
@rdmark rdmark force-pushed the 2358-crash-on-macos-when-client-connects-to-server-with-afpstats-enabled branch from 1941de6 to 2a5816f Compare November 1, 2025 09:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rdmark rdmark changed the title afpd: comprehensive handling of the afpstats D-Bus thread lifecycle afpd: afpstats init error handling; don't build on macOS Nov 1, 2025
@rdmark rdmark marked this pull request as ready for review November 1, 2025 09:31
andylemin
andylemin approved these changes Nov 2, 2025
View reviewed changes
Copy link
Contributor

@andylemin andylemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andylemin andylemin merged commit 93a5821 into main Nov 2, 2025
60 of 61 checks passed
@rdmark rdmark deleted the 2358-crash-on-macos-when-client-connects-to-server-with-afpstats-enabled branch November 2, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andylemin andylemin andylemin approved these changes

@cheesestraws cheesestraws Awaiting requested review from cheesestraws

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crash on macOS when client connects to server with afpstats enabled

3 participants

@rdmark @andylemin