Uses HashMap if CompactHashMap is not available on classpath.#1235
Merged
troshko111 merged 1 commit intoNetflix:masterfrom Sep 4, 2019
Merged
Uses HashMap if CompactHashMap is not available on classpath.#1235troshko111 merged 1 commit intoNetflix:masterfrom
troshko111 merged 1 commit intoNetflix:masterfrom
Conversation
This allows eureka users to exclude compactmap library if they so choose.
Contributor
|
Should the dependency be scoped as optional? eureka/eureka-client/build.gradle Line 21 in fb35597 |
Contributor
Author
|
@mattnelson I don't think so. I'm shooting for the defaults to stay the same. If it gets excluded, it still works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows eureka users to exclude compactmap library if they so choose.