Refactorings/transport #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional unit tests.
so different retry logic can be injected for registration and query operations
…ver' into refactorings/transport Conflicts: eureka-client/src/test/java/com/netflix/discovery/converters/EurekaJsonAndXmlJacksonCodecTest.java eureka-core/src/main/java/com/netflix/eureka/cluster/JerseyReplicationClient.java eureka-core/src/main/java/com/netflix/eureka/cluster/PeerEurekaNodes.java eureka-core/src/main/java/com/netflix/eureka/cluster/ReplicationTask.java eureka-core/src/test/java/com/netflix/eureka/cluster/JerseyReplicationClientTest.java eureka-core/src/test/java/com/netflix/eureka/cluster/TestableInstanceReplicationTask.java eureka-server/src/test/java/com/netflix/eureka/resources/EurekaClientServerRestIntegrationTest.java eureka-test-utils/src/main/java/com/netflix/discovery/util/DiagnosticClient.java
It is still an optional feature that must be explicitly enabled. By default the previous transport implementation is used.
eureka-client-jersey2 module is still work in progress, as DiscoveryClient has hard dependency on Jersey 1.x.
…ver' into refactorings/transport Conflicts: eureka-core/src/main/java/com/netflix/eureka/DefaultEurekaServerConfig.java eureka-core/src/main/java/com/netflix/eureka/EurekaServerConfig.java eureka-core/src/main/java/com/netflix/eureka/cluster/PeerEurekaNode.java eureka-core/src/main/java/com/netflix/eureka/cluster/PeerEurekaNodes.java eureka-core/src/main/java/com/netflix/eureka/cluster/ReplicationTask.java eureka-core/src/main/java/com/netflix/eureka/cluster/ReplicationTaskProcessor.java eureka-core/src/test/java/com/netflix/eureka/cluster/TestableInstanceReplicationTask.java
Vip query methods, and related support in DiscoveryClient were not implemented. The single, very long running test was refactored to shorten its execution time.
1.x Refactorings/transport
Refactorings/transport sync with master
…sport Conflicts: eureka-client/src/main/java/com/netflix/discovery/util/EurekaEntityFunctions.java
- created a transport specific config
1.x More test refactoring
1.x Tests refectoring
Intelligent resolvers for read operations
- a single jerseyClient is used for query, registration and httpResolver - a single bootstrap resolver (async wrapped) is used for query and registration resolvers
…efactorings/transport
Splitting query and registration clients for experimental transport
… query. - Tune down some logging
…viour is unchanged from today)
resolution can be dynamically changed.
Various updates for refactorings/transport
|
NetflixOSS » eureka » eureka-pull-requests #496 SUCCESS |
There was a problem hiding this comment.
Lets always use milliseconds. Using seconds is bad for unit tests.
There was a problem hiding this comment.
These were due to a bad diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull provides an abstraction over the transport layer of eureka-client. It also provides ways of resolving query targets that can handle intelligent pre-discovery query targets. For example this can be used for cases were readonly replicas of discovery servers can be deployed and queries are handled by the readonly replica, via an initial bootstrap resolve from the master replicas.
As of this current implementation, both the old and new code paths are preserved and the old code path is enabled by default. To use the new transport code, set the properties:
To use the intelligent query resolver, set the properties