Fix for issue #702 (handle charset provided in Content-Type header) #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NetflixOSS » eureka » eureka-pull-requests #547 SUCCESS |
|
NetflixOSS » eureka » eureka-pull-requests #548 SUCCESS |
| } | ||
| // If jackson-dataformat-xml available, initialize XML codecs | ||
| if (isJacksonXmlOnClasspath()) { | ||
| this.xmlEncoder = CodecWrappers.getEncoder("JacksonXml"); |
There was a problem hiding this comment.
Use class instead of raw strings here
There was a problem hiding this comment.
This might cause ClassNotFoundException if jackson-dataformat-xml is not on classpath.
…sues as jackson-dataformat-xml is a provided dependency We will get rid of XStream when doing bigger rewrite of eureka-client.
|
NetflixOSS » eureka » eureka-pull-requests #550 SUCCESS |
|
ship it |
tbak
pushed a commit
that referenced
this pull request
Feb 5, 2016
Fix for issue #702 (handle charset provided in Content-Type header)
tbak
pushed a commit
to tbak/eureka
that referenced
this pull request
Feb 8, 2016
…ader) This PR (compared to the previouse, undone one Netflix#739) checks for entity types and is applied only to eureka specific data structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.