Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Configuration-based Module Load #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2015
Merged

Configuration-based Module Load #191

merged 1 commit into from
Feb 17, 2015

Conversation

@adamschmidt
Copy link
Contributor

Added the ability to load modules from configuration (-x option on command line), removing the compile-time dependency. suro-server project can now specify modules as a runtime dependency.

Added the ability to load modules from configuration (-x option on co…
e9d1391 
…mmand line), removing the compile-time dependency. suro-server project can now specify modules as a runtime dependency.
@cloudbees-pull-request-builder
Copy link

NetflixOSS » suro » suro-pull-requests #5 ABORTED

@adamschmidt
Copy link
Contributor Author

How come this aborted? I'm guessing that one of the test stages got stuck and exceeded the build timeout of 20 mins?

@cloudbees-pull-request-builder
Copy link

suro-pull-requests #171 FAILURE
Looks like there's a problem with this pull request

@metacret
Copy link
Contributor

I will take a look at the build. I need to fix flaky tests but it was low
priority.

On Wednesday, February 11, 2015, CloudBees pull request builder plugin <
[email protected]> wrote:

suro-pull-requests #171
https://netflixoss.ci.cloudbees.com/job/suro-pull-requests/171/ FAILURE
Looks like there's a problem with this pull request

—
Reply to this email directly or view it on GitHub
#191 (comment).

@cloudbees-pull-request-builder
Copy link

suro-pull-requests #172 FAILURE
Looks like there's a problem with this pull request

@metacret
Copy link
Contributor

I found which test is stuck. I will fix and let you know, then you can merge the master and please update your PR.

@adamschmidt
Copy link
Contributor Author

Hi Jae, this should be OK now?

@metacret
Copy link
Contributor

Sure, I will merge today.

On Mon, Feb 16, 2015 at 3:17 PM, adamschmidt [email protected]
wrote:

Hi Jae, this should be OK now?

—
Reply to this email directly or view it on GitHub
#191 (comment).

metacret added a commit that referenced this pull request Feb 17, 2015
@metacret
Merge pull request #191 from adamschmidt/ExtensionModules
31c2ec9 
Configuration-based Module Load
@metacret metacret merged commit 31c2ec9 into Netflix:master Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamschmidt @cloudbees-pull-request-builder @metacret