ISSUES #118
Merged
ISSUES #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileBlockingQueue's default gc period changed to 1 minute from 1hour MessageSetReader's exception should truncate all messages Updated thrift gen files Added a few more test cases for FileBlockingQueue including multithreading HealthCheck is not closing TTransport because it's making server throw the following error: 2014-08-21 06:55:11,276 ERROR Thread-15 AbstractNonblockingServer$FrameBuffer - Read an invalid frame size of 0. Are you using TFramedTransport on the client side?
|
suro-pull-requests #87 FAILURE |
There was a problem hiding this comment.
Should we increment the dropped message count in this case?
There was a problem hiding this comment.
emptyRoutingKeyCount means dropped messages.
|
suro-pull-requests #89 SUCCESS |
MessageSetReader will increase DROPPED_COUNT on the exception MesageRouter will increase DROPPED_COUNT on emptyRoutingKey QueuedSink with sinkId will increase DROPPED_COUNT with the tag, sinkId
|
suro-pull-requests #90 SUCCESS |
metacret
added a commit
that referenced
this pull request
Aug 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileBlockingQueue's default gc period changed to 1 minute from 1hour
MessageSetReader's exception should truncate all messages
Updated thrift gen files
Added a few more test cases for FileBlockingQueue including multithreading
HealthCheck is not closing TTransport because it's making server throw the following error:
2014-08-21 06:55:11,276 ERROR Thread-15 AbstractNonblockingServer$FrameBuffer - Read an invalid frame size of 0. Are you using TFramedTransport on the client side?