Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Div12345
Copy link
Collaborator

@Div12345 Div12345 commented Jan 24, 2022

Closes #254

@sylvchev
Copy link
Member

Thanks for the PR. Following a feedback from BranDecode, I think it is best to have predictable run and session name, that is the first session is always session_0 and the first run is always run_0. For now, this is mostly the case, but not for all datasets. I corrected it on Schirrmeister2017, on MAMEM and on Lee2017 datasets. PhysionetMI returns a correct session but the runs are dataset specific (run_4, run_8, run_12, run_6, ...)
Could you try to update the code so that it returns consecutive run numbers starting from 0?

Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use f-string in MOABB to ensure code consistency. Once the changes are applied, we could merge.

Div12345 and others added 2 commits January 25, 2022 23:03
Co-authored-by: Sylvain Chevallier <[email protected]>
Co-authored-by: Sylvain Chevallier <[email protected]>
@sylvchev
Copy link
Member

Thanks @Div12345! Good work.

@sylvchev sylvchev merged commit 91c4713 into NeuroTechX:develop Jan 25, 2022
sylvchev pushed a commit that referenced this pull request Feb 22, 2022
* Set download dir test and example (#249)

* Update to dataset_search call in FilterBank Motor Imagery

* Removing completed #fixme

* Removing total_classes argument from dataset_search call in FilterBank MI

This was earlier deprecated in 55f77ae

* set_download_dir test and example

* adding pre-commit modifications

* Update whats_new.rst

* Update examples/changing_download_directory.py

Co-authored-by: Sylvain Chevallier <[email protected]>

* Update examples/changing_download_directory.py

Co-authored-by: Sylvain Chevallier <[email protected]>

* Bump pillow from 8.4.0 to 9.0.0 (#253)

Bumps [pillow](https://github.com/python-pillow/Pillow) from 8.4.0 to 9.0.0.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@8.4.0...9.0.0)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix Schirrmeister2017 error (#255)

* correct event loading error, renaming session and runs

* add whats new

* Removing dependency of Physionet MI download on mne method (#257)

* Update physionet_mi.py

* consistency of runs numbering

* Update whats_new.rst

* f-string edits

Co-authored-by: Sylvain Chevallier <[email protected]>

* f-string edits

Co-authored-by: Sylvain Chevallier <[email protected]>

Co-authored-by: Sylvain Chevallier <[email protected]>

* Correct MAMEM issues (#256)

* switch mamem session to runs, use predictable names

* update docstring in evaluation, for building documentation

* update Lee2017 docstring for correct documentation.

* update whats new

* switch SSVEP example to within session

* correct typo and rebase

* correct typos on examples

* Progress bars (#258)

* Progress bars for downloads using pooch functionality

* Rectification of f-string in PhysionetMI

* Evaluations subject level progress bar

CV test subject level in the case of CrossSubjectEvaluation

* Update poetry.lock

* Update pyproject.toml

* dependencies

* Apply suggestions from code review (mne.utils to tqdm direct)

Co-authored-by: Sylvain Chevallier <[email protected]>

* Update poetry.lock

* tqdm arg

* Update whats_new.rst

* Update mistune dep

Co-authored-by: Sylvain Chevallier <[email protected]>

* fix doc url in readme (#262)

* fix doc url in readme

* correct links in the docs

* Schirrmeister2017 High-Gamma Dataset from EDF (#265)

* loading Schirrmeister2017 High-Gamma Dataset from EDF

* remove commented import of requests module

* rename to session_0

* added 13 + 12 subjects speller datasets by huebner (#260)

* added 13 + 12 subjects speller datasets by huebner

* clean up legacy run splitting code

* added use_blocks_as_sessions parameter for data

Co-authored-by: Sylvain Chevallier <[email protected]>

* added Spot Auditory oddball dataset (#266)

* added Spot Auditory oddball dataset

* replaced usage of deprecated dl.data_path

Co-authored-by: Sylvain Chevallier <[email protected]>

* Visualize all ERP datasets (#261)

* Visualize all ERP datasets

* * use paradigm.datasets instead of manual list

* more verbose sanity check script

* fix epo data leak + remove title bf

* moved data visualization

added disclaimer regarding data size

Co-authored-by: Sylvain Chevallier <[email protected]>

* update to v0.4.5 (#269)

* update to v0.4.5

* update poetry and requirements

* correct pre-commit error and add code coverage (#271)

Co-authored-by: Divyesh Narayanan <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: robintibor <[email protected]>
Co-authored-by: Jan Sosulski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid relying on MNE to download dataset

2 participants