Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@FlashOnFire
Copy link
Contributor

@FlashOnFire FlashOnFire commented Nov 1, 2025

Follow up PR after #349

Added CI workflow that triggers when a version change is pushed (in nixfmt.cabal) to the master branch.
It automatically builds a static binary, tags the commit, and creates a GitHub release with notes pulled from CHANGELOG.md.

Example release: https://github.com/FlashOnFire/nixfmt/releases/tag/v4.1.0

Edit:
Just thought that, as an alternative, we could have a workflow that triggers when a release is published and simply appends the static binary to it. That way we can keep the release process as-is.
Let me know which option you prefer.

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Nixpkgs diff

Copy link
Collaborator

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thank you! Left a bunch of nits inline (I learned a bunch about github actions thanks to @infinisil and @MattSturgeon).

@jfly jfly moved this to Approved in Nix formatting Nov 11, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2025-11-11/72019/1

@FlashOnFire FlashOnFire force-pushed the release_workflow branch 6 times, most recently from 9a8d952 to 4757a52 Compare November 17, 2025 09:28
Copy link
Collaborator

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just waiting for #354 (comment) to be resolved and we can land this.

@FlashOnFire FlashOnFire force-pushed the release_workflow branch 2 times, most recently from 87b3682 to 926c4fd Compare November 18, 2025 08:58
@FlashOnFire
Copy link
Contributor Author

Just waiting for the pipeline to finish on my repo to check if everything works fine, and it should be good to go !
Let me know if you want me to change anything else

@FlashOnFire
Copy link
Contributor Author

It works properly on my side, you can check my test release here !

Copy link
Collaborator

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super close! Just a couple more unsafe interpolations.

Copy link
Collaborator

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jfly jfly merged commit b672593 into NixOS:master Nov 20, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Nix formatting Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants