Thanks to visit codestin.com
Credit goes to github.com

Skip to content

rulesets/nixpkgs: switch merge queue to "headgreen" strategy #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

rulesets/nixpkgs: switch merge queue to "headgreen" strategy #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rulesets/nixpkgs/require-merge-queue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"min_entries_to_merge": 1,
"max_entries_to_merge": 5,
"min_entries_to_merge_wait_minutes": 5,
Comment on lines 22 to 24
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're talking about finessing the numbers, we should look at tweaking these numbers soon.

In particular, I think we should:

  • Increase "max entries" (build & merge), so that we test & merge larger groups
  • Increase "min entries," so that we don't start testing until we have a few PRs queued
  • Consider decreasing "minutes to wait," so that we don't have to wait too long if the queue is really quiet for some reason (maybe 5m is ok already, though?)

Increasing the "max entries" is based on the assumption that failures will be rare. Therefore, we should optimistically attempt to test & merge larger groups, thereby speeding up the queue. Failures will delay more PRs, but the happy path will be faster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before tweaking these numbers, I think we should move more stuff to the queue first. Eval, Build etc. - right now, with the very basic queue, it might have very different behavior.

"grouping_strategy": "ALLGREEN",
"check_response_timeout_minutes": 60
"grouping_strategy": "HEADGREEN",
"check_response_timeout_minutes": 20
}
}
],
Expand Down