Thanks to visit codestin.com
Credit goes to github.com

Skip to content

treewide: implement lazy loading via lz.n for selected plugins #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 72 commits into from
Nov 4, 2024
Merged

treewide: implement lazy loading via lz.n for selected plugins #407

merged 72 commits into from
Nov 4, 2024

Conversation

@horriblename
Copy link
Collaborator

@horriblename horriblename commented Oct 6, 2024 •
edited
Loading

things maybe to do:

  • integrate into extraPlugins instead of using a separate option

bug:

  • there's this stupid bug where if you give only one plugin it doesn't work, I'll fix it upstream later fixed

@horriblename horriblename marked this pull request as draft October 6, 2024 20:02
@horriblename horriblename mentioned this pull request Oct 6, 2024
Closed
@NotAShelf NotAShelf mentioned this pull request Oct 7, 2024
Closed
@horriblename horriblename marked this pull request as ready for review October 7, 2024 00:38
@horriblename horriblename requested a review from diniamo October 7, 2024 00:38
@NotAShelf NotAShelf mentioned this pull request Oct 7, 2024
Merged
NotAShelf
NotAShelf requested changes Oct 8, 2024
View reviewed changes
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just being nitty at this point

haven't gone through the nix functions extensively, but from a glance they look alright - better if we test this live for a while in 0.7 after the merge

@horriblename horriblename changed the title Feature/lzn feature: lazy loading with lz.n Oct 9, 2024
NotAShelf
NotAShelf reviewed Oct 28, 2024
View reviewed changes
NotAShelf
NotAShelf previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotAShelf NotAShelf dismissed stale reviews from diniamo and themself October 28, 2024 08:21

stale

diniamo
diniamo suggested changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@diniamo diniamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run nix fmt as well

@NotAShelf NotAShelf changed the title feature: lazy loading with lz.n treewide: implement lazy loading via lz.n for selected plugins Nov 4, 2024
@horriblename horriblename merged commit 21fcace into v0.7 Nov 4, 2024
7 checks passed
@NotAShelf NotAShelf mentioned this pull request Nov 10, 2024
Closed
1 task
@NotAShelf NotAShelf deleted the feature/lzn branch November 10, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NotAShelf NotAShelf NotAShelf approved these changes

+1 more reviewer

@diniamo diniamo diniamo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@horriblename @diniamo @NotAShelf