Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Soliprem
Copy link
Collaborator

@Soliprem Soliprem commented Nov 9, 2024

Adding support for Assembly

Sanity Checking

  • I have updated the changelog as per my changes.
  • I have tested, and self-reviewed my code.
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt).
    • My code conforms to the editorconfig configuration of the project.
    • My changes are consistent with the rest of the codebase.
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual.
    • (For breaking changes) I have included a migration guide.
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@Soliprem Soliprem requested a review from NotAShelf as a code owner November 9, 2024 13:09
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick changes, LGTM otherwise.

@Soliprem Soliprem requested a review from NotAShelf November 9, 2024 18:38
@NotAShelf NotAShelf merged commit 1604c74 into NotAShelf:v0.7 Nov 9, 2024
7 checks passed
@github-actions github-actions bot deleted the asm branch December 15, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants