[IMP] help_popup module #417
Conversation
help_popup/model.py
Outdated
| # © 2015 David BEAL @ Akretion <[email protected]> | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
|
|
||
| from BeautifulSoup import BeautifulSoup as BSHTML |
There was a problem hiding this comment.
This is a new dependency, right? Isn't LXML suitable for the job?
|
I'm not trying to push anything on you, and only as a reminder it would be desirable that help_popup and help_online eventually converge into a single module. |
2656626 to
a09eefa
Compare
|
@dreispt why not, have you a plan in mind about functionalities that should stay or be extended and with which dependencies ? |
a09eefa to
2aa40c4
Compare
650e751 to
a850a7e
Compare
a850a7e to
cf27d3b
Compare
|
Hi, I have been reviewing this module with @bealdav and it looks very simple and useful. About @dreispt comment #417 (comment), I agree that it's better not to depend in website as help_online do: https://github.com/OCA/web/blob/9.0/help_online/__openerp__.py#L30 This module is very interesting as potentially could solve the problem of Odoo with a full functional documentation made by end-users. In this moment the doc which end user write down is stored in Odoo database so if I do the doc I must export somehow to import for my other customers. I will wait to have travis and runbot green to final review. |
02d3eb4 to
b70da3e
Compare
b70da3e to
0e1d9c1
Compare
help_popup/tests/test_help.py
Outdated
| # partner_act.advanced_help, | ||
| # u'\nnew_content<help_base>toto</help_base>', | ||
| # "Partially updating of 'ir.model'.advanced_help is broken") | ||
| # # partner_act.remove_obsolete_help('base') |
| try: | ||
| from bs4 import BeautifulSoup as BSHTML | ||
| except ImportError: | ||
| _logger.debug( |
There was a problem hiding this comment.
I guess this could be at least a warning error, if we want to install this module I guess this import is required
There was a problem hiding this comment.
this logger is for not installed module (oca guidelines)
There is raise in standard odoo installation module with 'external_dependencies' data in manifest.
No way to install if no dependency satisfied.
There was a problem hiding this comment.
please fix the tests: https://travis-ci.org/OCA/web/jobs/164951115#L544
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
When you click on 'Sales help' above, you open the report below (all documentation of the menu sales).Here is a dedicate view on action window to modify end users help fields