[8.0][ADD] web_search_nospace: remove redundant spaces when pasting content into search box #660

daramousk · 2017-06-29T10:43:45Z

When you paste content in the search bar that has whitespace characters before or after the search string thus causing the search to fail.

This module fixes that

oca-clabot · 2017-06-29T10:43:48Z

Hey @daramousk, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

George Daramouskas (no github login found)

Appreciation of efforts,
OCA CLAbot

hbrunn

if you painted the icon yourself, add its source too, if not, add a reference to where you got it and check that it has a free license in the first place

hbrunn · 2017-06-29T10:55:48Z

web_search_nospace/static/src/js/search.js

+ * (http://www.gnu.org/licenses/agpl.html).
+ */
+openerp.web_search_nospace = function(instance) {
+	instance.web.search.InputView = instance.web.search.InputView.extend({


don't do this. This way, you actually replace the InputView object, this can cause very hard to debug problems. Say use include instead, this modifies the existing object

hbrunn · 2017-06-29T10:57:47Z

web_search_nospace/__openerp__.py

+    This module trims the whitespace from the search bar in the end of your
+    search term.
+    """,
+    'version': "1.0",


use OCA's versioning scheme

daramousk · 2017-07-04T08:56:40Z

@hbrunn Implemented the changes

daramousk · 2018-09-13T12:18:35Z

@NL66278 A review here as well would be nice.

NL66278 · 2018-09-13T12:40:54Z

web_search_nospace/static/src/js/search.js

@@ -0,0 +1,16 @@
+/**
+ * © 2017 Therp BV <http://therp.nl> License AGPL-3.0 or later


Make it the full word Copyright. and use https://

NL66278 · 2018-09-13T12:43:09Z

web_search_nospace/static/src/js/search.js

+openerp.web_search_nospace = function(instance) {
+	instance.web.search.InputView.include({
+
+		onPaste : function() {


Why the large indents? Another :retab needed?

NL66278 · 2018-09-13T12:44:28Z

web_search_nospace/static/src/js/search.js

+
+		onPaste : function() {
+			this._super()
+			setTimeout(function() {


I am not an expert in Odoo javascript programming. But is the timeout really needed here? Can't we have simply: this.$el.text(this.$el.text().trim()); directly? Just asking...

@daramousk Please answer this question as well

@NL66278 Basically there were some timing/race condition issues from what I remember, you can see an explanation here https://stackoverflow.com/questions/779379/why-is-settimeoutfn-0-sometimes-useful.

@daramousk Did you actually experience these conditions? Because if I read up on the discussion on stackoverflow, especially the extended answer by DVK, this does not seem to apply here, but maybe I am mistaken.

@NL66278 Ok I just went back to this to remember why I used it. Basically I used it because it was used on the super call and for some reason the the changes to $el are not propagated unless you force it with setTimeout. If you remove the setTimeout the whole thing will not work at all.

Now why this happens I do not know, it's probably some obscure event handling mechanism. You can check the super call for more data.

OK, lets keep it as you made it.

NL66278 · 2018-09-13T12:45:02Z

web_search_nospace/views/assets_backend.xml

+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+	<data>
+		<template id="assets_backend" name="web_search_nospace.assets_backend"


More indentation problems.

simahawk

LG, just minor changes required

simahawk · 2018-10-15T06:59:58Z

web_search_nospace/README.rst

@@ -0,0 +1,40 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg


as this is a new module pls follow the new readme structure https://github.com/OCA/maintainer-tools/tree/master/template/module/readme

@simahawk Doesn't this readme follow the new structure? (some non necessary sections are omitted)

if you follow the link you see that the README.rst is not there anymore and is auto-generated w/ per-section files from /readme.
I don't see the dir so.... nope :)

simahawk · 2018-10-15T07:01:04Z

web_search_nospace/__init__.py

@@ -0,0 +1,3 @@
+# -*- coding: utf-8 -*-
+# © 2017 Therp BV <http://therp.nl>


copy is not needed in __init__, no mandatory to remove tho... but pls, replace ©️ w/ "Coypright"

web_search_nospace/__openerp__.py

nikul-serpentcs

minor change

nikul-serpentcs · 2018-10-15T07:09:09Z

web_search_nospace/__openerp__.py

+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+{
+    'name': "Search no space",
+    'author': "Therp BV, Odoo Community Association (OCA)",


@daramousk Add a website key as per this

web_search_nospace/__openerp__.py

NL66278

👍 LGTM. Please still remove last copyright symbol. Not blocking though. For the rest OK.

tarteo

Can you take a look at the lint issues https://travis-ci.org/OCA/web/jobs/480883417#L1686

NL66278 · 2019-01-17T14:19:48Z

@tarteo These lint errors are from a totally different module.

tarteo · 2019-01-17T14:26:02Z

@NL66278 Oops, I meant https://travis-ci.org/OCA/web/jobs/480883417#L1822

daramousk · 2019-04-25T12:03:51Z

@simahawk Simone, anything else that needs to be done here?

github-actions · 2022-04-03T12:32:36Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

hbrunn requested changes Jun 29, 2017

View reviewed changes

hbrunn reviewed Jun 29, 2017

View reviewed changes

yajo added the needs review label Jun 30, 2017

yajo added this to the 8.0 milestone Jun 30, 2017

hbrunn approved these changes Jul 4, 2017

View reviewed changes

NL66278 reviewed Sep 13, 2018

View reviewed changes

simahawk changed the title ~~[IMP] Fix redundant spaces when pasting content in the search~~ [8.0][ADD] web_search_nospace: remove redundant spaces when pasting content into search box Oct 15, 2018

simahawk requested changes Oct 15, 2018

View reviewed changes

nikul-serpentcs reviewed Oct 15, 2018

View reviewed changes

daramousk force-pushed the 8.0-web-search-nospace branch from 1f57dc5 to 147b321 Compare October 25, 2018 10:52

daramousk force-pushed the 8.0-web-search-nospace branch from f487cda to d19881e Compare January 16, 2019 15:04

NL66278 reviewed Jan 17, 2019

View reviewed changes

web_search_nospace/__openerp__.py Outdated Show resolved Hide resolved

NL66278 approved these changes Jan 17, 2019

View reviewed changes

daramousk force-pushed the 8.0-web-search-nospace branch from d19881e to a6167a4 Compare January 17, 2019 14:00

tarteo requested changes Jan 17, 2019

View reviewed changes

tarteo approved these changes Apr 23, 2019

View reviewed changes

[ADD] Adds web_search_nospace module.

bed767a

daramousk force-pushed the 8.0-web-search-nospace branch from 88196a0 to bed767a Compare June 11, 2019 09:17

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 3, 2022

github-actions bot closed this May 8, 2022

		@@ -0,0 +1,16 @@
		/**
		* © 2017 Therp BV <http://therp.nl> License AGPL-3.0 or later

		@@ -0,0 +1,40 @@
		.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg

		@@ -0,0 +1,3 @@
		# -- coding: utf-8 --
		# © 2017 Therp BV <http://therp.nl>

Uh oh!

[8.0][ADD] web_search_nospace: remove redundant spaces when pasting content into search box #660

[8.0][ADD] web_search_nospace: remove redundant spaces when pasting content into search box #660

Uh oh!

Conversation

daramousk commented Jun 29, 2017

Uh oh!

oca-clabot commented Jun 29, 2017

Uh oh!

hbrunn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daramousk commented Jul 4, 2017

Uh oh!

daramousk commented Sep 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simahawk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nikul-serpentcs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NL66278 left a comment

Choose a reason for hiding this comment

Uh oh!

tarteo left a comment

Choose a reason for hiding this comment

Uh oh!

NL66278 commented Jan 17, 2019

Uh oh!

tarteo commented Jan 17, 2019

Uh oh!

daramousk commented Apr 25, 2019

Uh oh!

github-actions bot commented Apr 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants