[FIX] web_export_view: Error when export a view with a many2many field. #812
Conversation
There was a problem hiding this comment.
I left comments what to change if you insist on this approach.
I think we'll be better off if you do what the client does (that's the trick of this module: Generate it the way the client presents it): https://github.com/OCA/OCB/blob/8.0/addons/web/static/src/js/view_list.js#L1109 You might have to slip in an inbetween step where you gather all ids of all many2many fields in the export to read
| record = new instance.web.list.Record(record).toForm(); | ||
| $.each(view.visible_columns, function() { | ||
| export_row.push( | ||
| this.type != 'integer' && this.type != 'float' ? |
There was a problem hiding this comment.
why don't you just add your exclusion here?
| request.env[cell['relation']].browse(cell['ids']) | ||
| ) | ||
| ) | ||
| if isinstance(cell, dict) else cell |
There was a problem hiding this comment.
don't guess stuff. Extend the protocol that it also passes the field names being exported. From this you can decide where to do anything at all and that relation to use. And don't copy around data, the id lists are references, you you can just replace those.
|
in #816 I fix this the way I propose and a few other issues, so I'd suggest to close this and review the latter. |
Hello,
With the latest version when you try to export a current view where is a m2m field we get an error.
To reproduce go to Sales --> Products --> Product variants, select any number of records and 'Export Current View', then:
(Tryed on runbot)
To fix this we implemented a case in the web_export_view.js for the m2m fields and in the controller.py we get the correct value acording to the m2m values.