[FIX] web_dialog_size: Fix usage for non-admins and reduce calls #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
pedrobaeza
approved these changes
Jun 12, 2018
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| To contribute to this module, please visit https://odoo-community.org. |
There was a problem hiding this comment.
Please don't remove totally this file, as runbot will fail. You have 2 options:
- Put a line like the template one:
**This file is going to be generated by oca-gen-addon-readme.** - Run oca-gen-addon-readme locally for generating the README and not letting the bot do it at night.
There was a problem hiding this comment.
why? doesn't it create it later automatically?
There was a problem hiding this comment.
Yeah, but meanwhile you will have a red build
|
Travis is red |
|
I'm afraid this is still red |
chienandalu
approved these changes
Jun 12, 2018
ernestotejeda
pushed a commit
to Tecnativa/web
that referenced
this pull request
Nov 22, 2018
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
pedrobaeza
pushed a commit
to Tecnativa/web
that referenced
this pull request
Dec 7, 2018
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
sudhir-erpharbor
pushed a commit
to sudhir-erpharbor/web
that referenced
this pull request
Oct 4, 2019
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
pierre-pizzetta
pushed a commit
to pierre-pizzetta/web
that referenced
this pull request
Oct 16, 2020
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
rapvalencia
pushed a commit
to WilldooIT/web
that referenced
this pull request
Jun 8, 2022
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
baimont
pushed a commit
to acsone/web
that referenced
this pull request
Aug 26, 2022
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
tarteo
pushed a commit
to tarteo/web
that referenced
this pull request
Mar 2, 2023
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
CarlosRoca13
pushed a commit
to Tecnativa/web
that referenced
this pull request
Aug 16, 2024
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
CarlosRoca13
pushed a commit
to Tecnativa/web
that referenced
this pull request
Aug 16, 2024
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
trisdoan
pushed a commit
to trisdoan/web
that referenced
this pull request
Aug 29, 2024
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
jeromeguerriat-msf
pushed a commit
to jeromeguerriat-msf/web
that referenced
this pull request
Dec 27, 2024
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
BhaveshHeliconia
pushed a commit
to HeliconiaIO/web
that referenced
this pull request
Oct 15, 2025
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon had 2 problems after migrating to v11:
ir.config_parameter.get_paramwas done foreach instantiated dialog, while the setting served for the whole
session equally.
couldn't use the default at all.
Fixed now.
@Tecnativa