Hi @SplashS, @Tardo, @yajo,
some modules you are maintaining are being modified, check this out!

Exactly, I see this feature very annoying, and should be at least configurable, but I don't really see why having the preview always (although not needed), and having to scroll down for the chatter is an improvement...

Exactly, I see this feature very annoying, and should be at least configurable,

👍

why having the preview always (although not needed)

i see this feature very important for accountant people. In my company,

• There a a lot of user that generate invoices. (no interesting for them)
• There are also accountants that are doing supplier invoicing control. For them, this feature saves 2 click.

The problem is that when you access an invoice, you don't want to see the attachment most of the times. Only for the initial encoding is needed, or some later checks. But the rest of the time, this preview is useless. And this only works when then first attachment is the correct one. I have for example one ISP vendor that attaches a PDF with the call list, and as second attachment, the invoice, so in this case, it's worst the solution than the illness.

Doing 2 clicks is not so bad then. One thing we can do is to unfold attachment by default (when there are any), so the preview is only 1 click away. I think Odoo does this on v17.

I think Odoo does this on v17.

Just tested on v17 :
-> the "just one click is NOT implemented"
-> but the V17 works EXACTLY like the current PR ;-)

When user click on an invoice and open a form view AND IF len(attachments)
---> the attachments[0] is displayed automatically in the right.
---> the chatter is in the bottom

I think Odoo does this on v17.

Just tested on v17 : -> the "just one click is NOT implemented" -> but the V17 works EXACTLY like the current PR ;-)

When user click on an invoice and open a form view AND IF len(attachments) ---> the attachments[0] is displayed automatically in the right. ---> the chatter is in the bottom

Yes, that's the same in v16 as well(also the double display). That is why I had made the change likewise

I think Odoo does this on v17.

Just tested on v17 : -> the "just one click is NOT implemented" -> but the V17 works EXACTLY like the current PR ;-)
When user click on an invoice and open a form view AND IF len(attachments) ---> the attachments[0] is displayed automatically in the right. ---> the chatter is in the bottom

Yes, that's the same in v16 as well(also the double display). That is why I had made the change likewise.
Also, if there are multiple attachments , it allows us to go through each of it by next/previous buttons

Well, as said, this was intentionally put this way on web_responsive for not acting like that, as such behavior is worst than the current (and in previous version one). It was explained in #2405 (comment), and discussed, being implemented as it is, so this should be put as an option, and disabled by default for stability reasons.

It was explained in #2405 (comment), and discussed, being implemented as it is

Thanks ! I didn't know all that analysis.

so this should be put as an option, and disabled by default for stability reasons.

👍

So, the current PR is fine , but only should be put as an option , right? @pedrobaeza

Check the issue commented by Sylvain, but if you put it as an option disabled by default, then go ahead. I suppose you put the option selectable per user, but it should also attend the core option for display it per model.

but it should also attend the core option for display it per model.

Yes, this preview only comes up when the attachment_preview div is added like how chatter_div is added on the form view.

I suppose you put the option selectable per user

Yes, which would be disabled by default

@legalsylvain and @pedrobaeza , can you please review it once now?

The preference field is not shown, and needed to add it manually to the UI

The Preference field would show up in My Profile section exactly how the chatter position options show up.

I'm seeing that web_chatter_position (I needed to uninstall it for avoiding interferences) has an option called "Sided", that seems to be thought for recovering this option. It's not working, but don't you think it's better to add this code in such module and have it all controlled the same way?

The web_chatter_position module may or may not be installed by everyone who use the web_responsive module so this change(code) has to be added in web_responsive module I believe.

And the sided option in web_chatter_position module doesn't work even if you uninstall the web_responsive module and check in invoices as this feature (Attachment Preview) is actually independent of the chatter position. So if needed, changes should also be added in the web_chatter_position module to allow/disallow Attachment Previews based on the chatter position or handle it any other way.