Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

legalsylvain
Copy link
Contributor

No description provided.

@legalsylvain legalsylvain added this to the 16.0 milestone Oct 12, 2024
@quentinDupont quentinDupont force-pushed the 16.0-mig-web_responsive_company branch 2 times, most recently from 4f2a5be to db13bcf Compare July 10, 2025 12:31
@quentinDupont
Copy link
Contributor

quentinDupont commented Jul 10, 2025

Migration with a lot of changes to fit with OWL and new way of selecting companies and log in

USAGE

  • Click on the current company name

  • The list of the companies are now displayed with the logo and the code (if defined)

company_menu
  • It is also possible to search by name, with a fuzzy search.
company_menu_fuzzy_search

Other features :

  • a new access key is available on 'Y' to display company menu.
  • navigate with keyboard 'Arrow down', 'Arrow up' and 'Tab'
  • toggle company off/on with 'Space' and log in with 'Enter'
  • escape fullscreen with 'Escape'
  • selected companies have a check mark
  • logged in company has a green check mark and a green border

@quentinDupont
Copy link
Contributor

@OCA/web-maintainers could you open this PR as my colleague Sylvain is currently off work :)

@quentinDupont
Copy link
Contributor

First module for me with OWL. Don't hesitate to criticize, I'm not a JS expert at all

@tarteo tarteo marked this pull request as ready for review July 10, 2025 16:00
@legalsylvain
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@legalsylvain The rebase process failed, because command git push --force grap tmp-pr-2955:16.0-mig-web_responsive_company failed with output:

remote: Permission to grap/web.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/grap/web/': The requested URL returned error: 403

@quentinDupont quentinDupont force-pushed the 16.0-mig-web_responsive_company branch from db13bcf to fb9ab8a Compare September 16, 2025 12:46
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, I have tested it on runboat. There's a small bug I found, it's when:

  1. I opened the company switcher search for e.g. "YourCompany"
  2. hide the company switcher
  3. and then open the switcher again
  4. the query is still active but not visible in the search input
image

/* Search-input is built on DOM with toggle dropdown
Can surely be handled more cleanly */
_onClickToggler() {
const tryFocus = (retries = 10) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible to use this.searchInputRef.el here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants