Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

thomaspaulb
Copy link

Funny, I've been having discussions about this in the board before, and now it happens to me for the first time, that I'm aware of.

Issue I have:

  • Customer is using mrp_production_serial_matrix which depends on this module web_widget_x2many_2d_matrix. Because the matrix module was AGPL, all dependencies are, and rightfully should be.
  • However, customer is also using Odoo quality_mrp module.
  • quality_mrp does not play well with the matrix, so I need to make a glue module, which I think I'm not allowed to do, because it would depend both on an AGPL module and an Enterprise module, which have incompatible licenses.

Do I have any other choice than this?

@thomaspaulb thomaspaulb self-assigned this Jun 1, 2025
@thomaspaulb
Copy link
Author

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jun 3, 2025
@NL66278
Copy link
Contributor

NL66278 commented Jun 4, 2025

@thomaspaulb There is also a module called quality_mrp_oca. Did not study this in detail, but could it not be a plugin compatible module for quality_mrp?

@thomaspaulb
Copy link
Author

That will have to involve them switching fully from Enterprise quality suite to OCA quality suite. I'm not ready to bear the burden of that currently

pedrobaeza

This comment was marked as outdated.

@rvalyi
Copy link
Member

rvalyi commented Jun 4, 2025

I think you should also adapt the headers in the files.

@pedrobaeza you approved the PR but your comment kind of mean you would disagree. Did you approved by mistake? Did I miss something?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally won't relicense any of my backend modules to LGPL. Anyway, I would say that the license incompatibility is the other direction, isn't it? @dreispt can say about it.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To increase adoption and attract more contributors, we propose changing the license of this module to LGPL, with consent from all authors.

LGPL reduces barriers for companies and SaaS providers, without compromising the spirit of open collaboration.

It’s a simple step to keep this module alive, useful, and growing.

@dreispt
Copy link
Member

dreispt commented Jun 4, 2025

Although the OCA can use the CLA to change a license (more precisely, can sublicense to an OSI-approved license), we don't want to do that against the will of the original authors.

Note that later contributions, migrations, refactors, etc. do not grant authorship.

Looking at the history of this module, it seems that the original author is @hbrunn under Therp BV.
If this is inaccurate, we can hear from other people that may claim co-authorship.

At this point, we would need this PR to be approved by a Therp representative.

@dreispt
Copy link
Member

dreispt commented Jun 4, 2025

@thomaspaulb

quality_mrp does not play well with the matrix, so I need to make a glue module, which I think I'm not allowed to do, because it would depend both on an AGPL module and an Enterprise module, which have incompatible licenses.

This is correct.
Is it an option that the source of the incompatibility can be resolved directly in web_widget_x2many_2d_matrix?

@thomaspaulb
Copy link
Author

The issue is actually with mrp_serial_number_matrix, which depends on this module, so both modules would need a license change.

I did find a "goat's path" though: we can make a module that depends only on quality_mrp, which will make it play well.

@thomaspaulb
Copy link
Author

Me being the Therp representative, I could decide now then to merge this. I'm personally leaning towards the license change because this matrix module is meant as a tool to be widely used in all kinds of dependent modules. Though it could also mean that it's going to be used as part of third party closed source modules, on the app store. Tough choice. @hbrunn what's your opinion on the matter?

@dreispt
Copy link
Member

dreispt commented Jun 4, 2025

Yes, indeed Tom.
If Holger wrote this under contract with Therp, then Therp would hold the authorship
Let's wait a bit to hear from Holger or other people.

Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update license in files as well. Eg here

@hbrunn
Copy link
Member

hbrunn commented Jun 5, 2025

@thomaspaulb I typically neither approve nor block this kind of license change, so do what you feel you need to be doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants