-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[16.0][MIG] web_form_banner: Migration to 16.0 #3298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactor JS: - Switch to the ESM style - Change var to const/let - Remove unused parts (diff, el.dataset.wfbTriggerFields) Miscellaneous improvements: - list view optional - Switch archive box icon to banner Co-authored-by: Yoshi Tashiro <[email protected]>
460f85a to
5c4a2a1
Compare
|
Hi @AungKoKoLin1997 and @yoshiro Thanks a lot for your nice module. |
b3c8879 to
222232f
Compare
|
Thanks @bealdav ! We'd also prefer to minimize JS, but dynamic banner updates are a hard requirement from a client, and I'm sure some people will find it useful as well. I also assume that JS changes required in future migrations will be relatively limited after this version. We still need to tidy up the commits, but the code is ready for review! :) |
222232f to
5ead4c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and functional test.
|
Thanks a lot @yostashiro for your answer. Do you plan to port this module to upper version like 18.0 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionnaly tested, thanks a lot.
@bealdav Yes, we plan to migrate to v17 and v18 in the next couple of days. |
- Add (partial) support for elements inside groups to be a target XPath without distorting the presentation - Remove obsolete bits - Remove lru_cache decorator
5ead4c3 to
85f01b3
Compare
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
It looks like something changed on |
|
Congratulations, your PR was merged at 3febd70. Thanks a lot for contributing to OCA. ❤️ |
Based on #3287
The module adds configurable banners for backend form views. Define rules per model
(and optionally per view) to show context-aware alerts with a chosen severity (info/warning/danger).
Messages can be plain text with ${placeholders} or fully custom HTML; visibility,
severity, and values are computed server-side via a safe Python expression.
Banners are injected just before or after a target node (default: //sheet) and refresh
on form load/save/reload.
@qrtl QT5747