-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[19.0][MIG] web_responsive: Migration to 19.0 #3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
* Add Tecnativa as author * Remove untestable JS method * Rename to web_responsive
* Bump version * Change all openerp to odoo * Fix qunit suite injection * Remove jQuery require * Change to new selectors: * `oe_leftbar` to `o_sub_menu` * `oe_logo` to `o_sub_menu_logo` * `oe_footer` to `o_sub_menu_footer` * `oe_secondary_menus_container` to `o_sub_menu_content` * Add style to hide oe_footer instead of remove to not break `support_branding` * Add note in ReadMe explaining override of `support_branding` * Set top margin of app drawer title to 0 to fit v10 proportions * Fix notification badge positioning * Add o_web_client class to body to fix overlaps * Scroll control panel with page * Change navbar z-index to not be overlapped by buttons * Raise z-index on header to raise over buttons * Handle layered notifications via z-index * Remove `#` from navigation links HREF to prevent history littering
* Rebalance z-indexes to fix overlay issue while still providing notification support
* Bold titles for apps in the app-drawer * Remove z-index from Control Panel buttons, so it doesn't overlap the menu. * Better responsive menus * Move systray icons/menus out of the menu and up to the top bar. * Increase avatar size and visibility. * Other minor menu behavior fixes. * Changes to fit odoo variables * And a little margin adjust on navbar-right * Top menu always thick * Removed overflow:hidden!important from main.less * Local patch: prevent body overflow auto * Stop using `style=` on `<body>` * Fix jquery drawer in anticipation of: blivesta/drawer#36
On screens with less than 768px content is limited to 2 columns. On mobile field labels have their own line. Fix elements width for XS screens
Make image editing controls always available, instead of depending on resolution or hover.
Small makeup to make it look good in XS screens.
* [IMP] drawer-toggle * [IMP] Hitbox of close drawer-toggle * [IMP] Removed outline on menu item * [IMP] Logo positionings * [FIX] Try me on runbot button * [REM] Reversed outline change
* Change accesskey for `edit` in form view back to `e` to fix OCA#587
Before this patch, there was an incompatibility between this addon and l10n_es_toponyms, caused by the lack of wrapping of the special address field that was being added. Now layout works as expected in that case. In any other case, it seems sensible to wrap inputs so no more weird overflows happen and less chances of needing horizontal scrolling happen.
* Initial commit * Initial commit
* FIX hasclass * FIX views * [FIX] web_responsive: Syntax error in xpath
* Update to iScoll bleeding edge to fix OCA#741
* Add a call to the window resize method during init to fix OCA#773
Currently translated at 29.0% (9 of 31 strings) Translation: web-18.0/web-18.0-web_responsive Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_responsive/fr/
Currently translated at 86.6% (26 of 30 strings) Translation: web-18.0/web-18.0-web_responsive Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_responsive/fr_BE/
Currently translated at 100.0% (31 of 31 strings) Translation: web-18.0/web-18.0-web_responsive Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_responsive/es/
The patch of stepUtils is breaking tests that uses this function when this module is installed. So remove it to avoid them fail.
The selectors used in clickbot.js from the Community Edition do not match any elements in the view when web_responsive is installed. Since the functions are not exported, we can't intercept them directly. To solve this, we override the querySelector functions specifically within the clickbot assets, allowing us to adjust the selectors when they are incompatible with web_responsive.
Currently translated at 96.7% (30 of 31 strings) Translation: web-18.0/web-18.0-web_responsive Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_responsive/tr/
|
You can give us your opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On most is ok, but a commented code is not necessary after I saw changes between 18.0 and 19.0.
| <!-- <xpath expr="//SuggestedRecipientsList" position="attributes">--> | ||
| <!-- <attribute name="styleString">''</attribute>--> | ||
| <!-- </xpath>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it is useless can be removed or even add the best code for version 19.0?
| <!-- <xpath expr="//SuggestedRecipientsList" position="attributes">--> | ||
| <!-- <attribute name="styleString">''</attribute>--> | ||
| <!-- </xpath>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I reviewed the code, I think the comment can be removed.
d004160 to
ec20678
Compare
ec20678 to
b5f524b
Compare
|
@pedrobaeza : I’ve fixed those issues. Thank you for pointing them out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot migration web_responsive
|
ping @kobros-tech |
|
Please check if this PR is necessary in V19 #3323 |
b5f524b to
89bfa02
Compare
The purpose is to reduce spacing so that all icons and buttons fit within the window without having to scroll.
89bfa02 to
593e963
Compare
I’ve done the cherry-pick. Thanks! |
|
No description provided.