[18.0][IMP] web_theme_classic Add dark mode and some cleanup #3322
Conversation
|
Hi @legalsylvain, |
|
Hi @ljmnoonan thanks for this PR, I started looking at how to improve borders on monetary fields and realized you did it as well ! Would you mind trying to also fix the currency symbol which is not aligned with amount : While testing, I found out that adding align-self: center;does the trick (although Firefox reports that it has no effect) |
f203db2 to
bfe3fe8
Compare
|
@remi-filament, thank you very much for the heads up! Screenshots: |
Prefix all vars with "wtc-" in order to prevent them from overriding or being overridden by bootstrap vars. Suffix all vars with !default to ensure that they can be overriden by dark mode. Add $wtc-input-color-required to ensure text contrasts on $wtc-input-background-color-required. This is especially necessary in instances like the quantity and unit price columns of a sale order because by default these fields are set to a light blue. Add CSS selectors to consistently handle many2many fields added as a custom property Remove border on .note-editable, i.e. the HTML editor. This feature was broken and, as far as I am concerned, unnecessary. Fix monetary field selectors. Previous code was using an id selector which is against odoo guidelines and ignores fields like expected_revenue in crm.lead Remove all button customization as it was all broken and is superceeded by OCA/web/web_save_discard_button anyways.
web_dark_mode is not merged yet. OCA#3267 And my CSS overhaul here: lambdao-dev#1
bfe3fe8 to
acb7550
Compare
There was a problem hiding this comment.
Great, thanks @ljmnoonan it is much better and I think current limitations are accceptable (were already there before I guess) !
Maybe it is worth adding them in README in ROADMAP section ?
|
This PR has the |
|
Hi. ready to merge ? regards |
|
@legalsylvain |
This could be 2 separate PRs, so please let me know if you would like me to split them.
The original purpose of this PR was to make this module play with web_dark_mode as promised in my previous PR, #3294. This is implemented in f203db2. Please note that it is dependent on #3267 and also on my PR to the fork where it came from here. I hope that these will be merged soon.
Here are some screenshots of this module in use in conjunction with web_dark_mode:
Before:
After:
However, while implementing the dark mode assets, I discovered a whole bunch of broken features and deficiencies in the existing code, so I decided to go about fixing them. All the changes are detailed in the commit message on 35f93db, but I will attach some before and after pictures here for clarity.
Add $wtc-input-color-required
Before:
After:
Add CSS selectors to consistently handle many2many fields added as a custom property
Before:
After:
Fix monetary field selectors.
Before:
After:
Please let me know if you would like any changes!