-
-
Notifications
You must be signed in to change notification settings - Fork 209
[15.0][MIG]stock_move_source_relocate : Migration to V15 #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
bizzappdev
wants to merge
216
commits into
OCA:15.0
from
BizzAppDev-Systems:15.0-mig-stock-move-source-relocate-BAD-TUG
Closed
[15.0][MIG]stock_move_source_relocate : Migration to V15 #592
bizzappdev
wants to merge
216
commits into
OCA:15.0
from
BizzAppDev-Systems:15.0-mig-stock-move-source-relocate-BAD-TUG
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When: * using a 3 steps delivery * creating and confirming a sale order * opening the transfer using the "Deliveries" button on the sale order * clicking on the "Release" button The pickings generated by the release are incorrect. This is because the smart button of the sale order view adds several "default_" fields that are then interpreted during the creation of the chained pickings. Clean these fields from the context.
When stock moves have been released, their 'need_release' flag must be set to False. Due to a coding mistake, they were not. The most visible effect was the "Release" button still visible on transfers and moves, but other vicious effects can't be excluded. The issue come from an inversion in the order of the list comprehension, added up to the fact that the 'procurement' variable name was recycled from the code above: 'procurement' was always equal to the latest procurement used in the loop before the list comprehension.
To reproduce * Order 100x [E-COM10] * Update quantities in stock to have 70 [E-COM10] in Stock/Shelf 1 * Release the moves Actual result: 2 transfer, the backorder for the waiting 30 [E-COM10] has no backorder link with the original transfer Expected result: 2 transfer, the backorder for the waiting 30 [E-COM10] has a backorder link with the original transfer
Current behavior: When we release an OUT stock move, the OUT transfer is set to printed. The origin transfers (e.g. Pick+Pack) are not. Expected behavior: When we release an OUT stock move, all the origin transfer (e.g. Pick+Pack) are set to printed. Reason: The original reason for setting "printed" to True, is that when "_assign_picking()" is called on a stock.move, the stock.move can be added only in a stock.picking which is not printed yet. In other terms, "printed" means the transfer has been started and shouldn't be modified. When we "release" moves, we actually planify the work to be done, and if we release again new moves, we don't expect transfers of the 2 waves of releases to be merged together. If we set the flag "printed" on the Out transfer only, we can end up with one Packing transfer leading to 2 Out transfers, which generally doesn't make sense.
0c8aa0d to
0f87895
Compare
Add relocation rules for moves. Some use cases: * Handle all the replenishments at the same place * Trigger minimum stock rules or DDMRP buffers in one location Behavior: * When we try to assign a stock move and the move is not available, a rule matching the source location (sub-locations included), the picking type and an optional domain is searched * If a relocation is found, the move source location is updated with the new one * If the move was partially available, it is split in 2 parts: * one available part which keeps its source location * one confirmed part which is updated with the new source location
Currently translated at 100.0% (28 of 28 strings) Translation: wms-13.0/wms-13.0-stock_move_source_relocate Translate-URL: https://translation.odoo-community.org/projects/wms-13-0/wms-13-0-stock_move_source_relocate/es_AR/
To remove the duplicate implementation of StockLocation.is_sublocation_of()
[UPD] Update stock_move_source_relocate.pot
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: wms-13.0/wms-13.0-stock_move_source_relocate Translate-URL: https://translation.odoo-community.org/projects/wms-13-0/wms-13-0-stock_move_source_relocate/
Update stock_move_source_relocate/models/stock_move.py Co-authored-by: Sébastien Alix <[email protected]>
0f87895 to
ec6ef56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.