Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sbejaoui
Copy link

@sbejaoui sbejaoui commented Jul 1, 2025

@OCA-git-bot
Copy link
Contributor

Hi @sebalix, @guewen, @mmequignon, @JuMiSanAr, @simahawk,
some modules you are maintaining are being modified, check this out!

@sbejaoui sbejaoui force-pushed the 16.0-shopfloor_reception_expiry_date-sbj branch from 48adfe3 to 6b9bcc6 Compare July 1, 2025 16:09
@rousseldenis rousseldenis added enhancement New feature or request needs review labels Jul 2, 2025
@rousseldenis rousseldenis added this to the 16.0 milestone Jul 2, 2025
@rousseldenis rousseldenis changed the title [IMP] shopfloor_reception: warn user if expiry date is in the past & block if missing [IMP] shopfloor_reception: warn user if expiry date is in the past & block if missing + add parsing for expiration date Jul 4, 2025
@rousseldenis rousseldenis force-pushed the 16.0-shopfloor_reception_expiry_date-sbj branch 2 times, most recently from ac1ce5c to 4658146 Compare July 4, 2025 13:57
@rousseldenis rousseldenis changed the title [IMP] shopfloor_reception: warn user if expiry date is in the past & block if missing + add parsing for expiration date [IMP] shopfloor_reception: several improvements Jul 9, 2025
@rousseldenis rousseldenis force-pushed the 16.0-shopfloor_reception_expiry_date-sbj branch from 6893b49 to 94ea20f Compare July 9, 2025 07:10
@jbaudoux jbaudoux changed the title [IMP] shopfloor_reception: several improvements [IMP] shopfloor_reception: lot expiration date Jul 18, 2025
sbejaoui and others added 3 commits August 27, 2025 09:38
…expiration date

If we use the GS1 shopfloor extension, we need to get the expiration date from lot
barcode is supplied in it.
@rousseldenis rousseldenis force-pushed the 16.0-shopfloor_reception_expiry_date-sbj branch 2 times, most recently from c2e3cd2 to 3e09f70 Compare September 1, 2025 13:42
In Odoo, as soon as lot_name field and expiration_date one are filled in,
lot will be created from those values if it does not exists. We should
inform user that the line is ready and has all the information in that case.
As in Odoo backend, lot name could have been set to generate the lot with the
expiration date at move line validation. We need it to get the information
the lot is ready on user side
@rousseldenis rousseldenis force-pushed the 16.0-shopfloor_reception_expiry_date-sbj branch from 3e09f70 to b33c9de Compare September 1, 2025 13:46
@rousseldenis
Copy link

@lmignon @phschmidt

@lmignon lmignon force-pushed the 16.0-shopfloor_reception_expiry_date-sbj branch from ed51fb3 to e403d4f Compare September 5, 2025 06:56
…piraton date

The set_lot method is quite complex and had multi purpose. It's called
multiple times by the JS code to fill the lot name and the expiration date.
Each call is independent and the method must handle all the cases. That's
mean the method must take care of the previous values provided by the user
at each call and ensure that the couple lot name/expiration date is valid.

Before this change, if a first call was done with a lot name, an existing lot
or a new one was linked to the move line. Then if a second call was done with
an expiration date, the method updated the existing lot with the new
expiration date. This could lead to inconsistencies if an existing lot
already linked to quant packages was updated with a different expiration date.
In addition, if the user changed the lot name on a new call, a new lot
was created even if the previous created lot was not used.

To void these issues, the implementation has been changed to never created
or update an existing lot and detect which parameter has explicitly been
provided by the user.

In any case, the couple lot name/expiration are checked to ensure they are
consistent. We detect if an existing lot could conflict with the provided
values. At the same time, at first call, if a lot is found for the provided
lot name and/or expiration date, we fill the missing value to help the user.

As result, a main change is that the lot is now created when the line
is validated.
Ensures that the value entered into the UI is properly converted into UTC according to the warehouse timezone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants