-
-
Notifications
You must be signed in to change notification settings - Fork 209
[16.0] shopfloor_mobile: align w/ v18 linting #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
|
@lmignon or @rousseldenis wold you mind having a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
shopfloor_mobile/static/wms/src/components/detail/detail_location.esm.js
Outdated
Show resolved
Hide resolved
6d4a426 to
921e696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be good now
shopfloor_mobile/static/wms/src/i18n/add_translations_to_registry.esm.js
Outdated
Show resolved
Hide resolved
921e696 to
5cba1d7
Compare
5cba1d7 to
fb91de3
Compare
|
Fixes applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this hard work @simahawk
LGTM (Code + little functional test with runboat)
Apply the same linting changes from v18 that apply as well to 16, to ease bkp/fwd porting.