-
-
Notifications
You must be signed in to change notification settings - Fork 194
[18.0] [MIG] contract_payment_mode_brand #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0] [MIG] contract_payment_mode_brand #260
Conversation
[ADD] - account invoice: define allowed payment mode per brand. [ADD] - limit payment mode selection is sale order to the brand allowed payment mode. [ADD] - limit payment mode selection is contract to the brand allowed payment mode [IMP] - Use a an abstract model for onchange_brand_allowed_payment_mode [FIX] - Fix dependencies Add brand to account_payment_mode_brand dependencies Co-Authored-By: Daniel Reis <[email protected]> [IMP] - use one onchange payment mode method in the abstract model [IMP] - use related field to filter allowed payment mode
28192ee to
71ad568
Compare
|
The tests for the PR contract_payment_mode_brand are failing due to dependencies on other modules' tests, Do you have any suggestions or best practices for handling this situation, other than pushing a PR to modify the brand module tests to include appropriate tags? |
|
/ocabot migration contract_payment_mode_brand |
38ec0bb to
894860c
Compare
| @@ -0,0 +1,2 @@ | |||
| This addon limit payment mode selection is contract to the brand allowed | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This addon limit payment mode selection is contract to the brand allowed | |
| This addon limits payment mode selection in contract to the brand's allowed |
|
The typo were in the original module. You might want to check your email config as the commit is not bind to your GitHub account |
894860c to
7e23263
Compare
|
@yvaucher Done |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 5ec0a3e. Thanks a lot for contributing to OCA. ❤️ |
No description provided.