Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@samirGuesmi
Copy link
Member

No description provided.

sbejaoui and others added 5 commits May 27, 2025 12:01
[ADD] - account invoice: define allowed payment mode per brand.

[ADD] - limit payment mode selection is sale order to the brand allowed payment mode.

[ADD] - limit payment mode selection is contract to the brand allowed payment mode

[IMP] - Use a an abstract model for onchange_brand_allowed_payment_mode

[FIX] - Fix dependencies

Add brand to account_payment_mode_brand dependencies

Co-Authored-By: Daniel Reis <[email protected]>

[IMP] - use one onchange payment mode method in the abstract model

[IMP] - use related field to filter allowed payment mode
@samirGuesmi samirGuesmi force-pushed the 18.0-mig-contract_payment_mode_brand branch 5 times, most recently from 28192ee to 71ad568 Compare June 3, 2025 15:18
@samirGuesmi
Copy link
Member Author

samirGuesmi commented Jun 4, 2025

The tests for the PR contract_payment_mode_brand are failing due to dependencies on other modules' tests,
specifically, the tests in the brand module are failing.
Generally, this issue can be resolved by tagging the brand module tests with post-install. However, as it stands, the brand module does not require such tags by default.

Do you have any suggestions or best practices for handling this situation, other than pushing a PR to modify the brand module tests to include appropriate tags?
@sbejaoui

@yvaucher
Copy link
Member

/ocabot migration contract_payment_mode_brand

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 29, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 29, 2025
17 tasks
@samirGuesmi samirGuesmi force-pushed the 18.0-mig-contract_payment_mode_brand branch 2 times, most recently from 38ec0bb to 894860c Compare September 16, 2025 08:25
@@ -0,0 +1,2 @@
This addon limit payment mode selection is contract to the brand allowed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This addon limit payment mode selection is contract to the brand allowed
This addon limits payment mode selection in contract to the brand's allowed

@yvaucher
Copy link
Member

The typo were in the original module.

You might want to check your email config as the commit is not bind to your GitHub account

@samirGuesmi samirGuesmi force-pushed the 18.0-mig-contract_payment_mode_brand branch from 894860c to 7e23263 Compare September 16, 2025 14:14
@samirGuesmi
Copy link
Member Author

@yvaucher Done

@OCA OCA deleted a comment from OCA-git-bot Sep 17, 2025
@yvaucher
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-260-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8493d7a into OCA:18.0 Sep 17, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5ec0a3e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants