Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[18.0][MIG] brand_external_report_layout #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bosd wants to merge 50 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] brand_external_report_layout #224

bosd wants to merge 50 commits into from

Conversation

@bosd
Copy link
Contributor

@bosd bosd commented Feb 10, 2025 •
edited
Loading

depends upon: #217

sbejaoui and others added 23 commits February 10, 2025 21:08
@sbejaoui @bosd
[12.0][IMP] - manage different report layouts by brand
4243c5e
@sbejaoui @bosd
[12.0][IMP] - Add unit tests
bfd3294
@sbejaoui @bosd
[12.0][IMP] - Add ROADMAP file to readme
78fa48f
@sbejaoui @bosd
[12.0][RMV] - Remove useless section in readme
01dc2e8
@sbejaoui @sbidoul @bosd
[12.0][IMP] - Change field label
050f44b 
Co-Authored-By: Stéphane Bidoul (ACSONE) <[email protected]>
@OCA-git-bot @bosd
[ADD] icon.png
4d006c7
@OCA-git-bot @bosd
brand_external_report_layout 12.0.1.0.1
944c01e
@jguenat @bosd
[12.0][FIX]-report_template
b53dac0
@OCA-git-bot @bosd
brand_external_report_layout 12.0.1.0.2
efa6c1d
@cubells @bosd
[MIG] brand_external_report_layout: Migration to 13.0
9e1bd83
@Freni-OSI @bosd
[14.0][MIG] brand_external_report_layout
97968a3
@oca-travis @bosd
[UPD] Update brand_external_report_layout.pot
0e453a8
@OCA-git-bot @bosd
[UPD] README.rst
08fefa1
@Murtaza-SerpentCS @bosd
[14.0][FIX] brand_external_report_layout.
1a2cbff
@sbejaoui @bosd
pre-commit
3ca4085
@OCA-git-bot @bosd
brand_external_report_layout 14.0.1.0.1
521b0d4
@sbejaoui @bosd
[IMP] - add Brand Document Layout
16d92d4
@sbejaoui @bosd
[MIG] - brand_external_report_layout migration 15.0
eb1eb76
@bosd
[UPD] Update brand_external_report_layout.pot
ad317b0
@OCA-git-bot @bosd
[UPD] README.rst
a19ab0d
@sbejaoui @bosd
[16.0][MIG] - migration brand_external_report_layout to 16.0
8058312
@bosd
[UPD] Update brand_external_report_layout.pot
336be2b
@OCA-git-bot @bosd
[UPD] README.rst
6bdff17
@bosd bosd marked this pull request as ready for review February 10, 2025 20:39
@bosd bosd mentioned this pull request Feb 10, 2025
Open
@bosd bosd force-pushed the 18.0-mig-brand_external_report_layout3 branch from 6501083 to c0c083b Compare February 22, 2025 14:32
@bosd bosd mentioned this pull request Feb 22, 2025
Closed
@bosd bosd mentioned this pull request Mar 11, 2025
Open
17 tasks
@bosd bosd force-pushed the 18.0-mig-brand_external_report_layout3 branch from c0c083b to 9e5ae8f Compare April 2, 2025 10:28
@bosd bosd mentioned this pull request Apr 2, 2025
Open
@yvaucher
Copy link
Member

yvaucher commented Jul 29, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 29, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 29, 2025
@OCA-git-bot
Merge PR #224 into 18.0
8e239a6 
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 29, 2025

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@bosd
Copy link
Contributor Author

bosd commented Aug 29, 2025

@max3903 Can you please merge?

@bosd
Copy link
Contributor Author

bosd commented Aug 30, 2025

@yvaucher Can you retry the merge?

@yvaucher
Copy link
Member

yvaucher commented Sep 15, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 15, 2025

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 15, 2025
@OCA-git-bot
Merge PR #224 into 18.0
dde4d9f 
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 15, 2025

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yvaucher
Copy link
Member

yvaucher commented Sep 15, 2025

@bosd partner_brand/tests/test_partner_brand.py", line 66, in test_empty_brand_logo is failing. Have you checked for conflict with another module?

@yvaucher
Copy link
Member

yvaucher commented Sep 15, 2025

@bosd PS are you at the OCA Days?

@bosd
Copy link
Contributor Author

bosd commented Sep 15, 2025

@bosd PS are you at the OCA Days?
Will be there this evening and tomorrow.

Have not checked it with conflicting modules.

@yvaucher
Copy link
Member

yvaucher commented Sep 17, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 17, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 17, 2025
@OCA-git-bot
Merge PR #224 into 18.0
a94b12b 
Signed-off-by yvaucher
@yvaucher
Copy link
Member

yvaucher commented Sep 17, 2025

With the patch on partner_brand it should not interfer with the other module. Let's see if the merge works.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 17, 2025

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

yvaucher
yvaucher reviewed Sep 17, 2025
View reviewed changes
brand_external_report_layout/models/res_brand.py

logo = fields.Binary(
related="partner_id.image_1920",
default=_get_default_brand_logo,
Copy link
Member

@yvaucher yvaucher Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the cause of the failing tests. As it sets a default value. And partner_brand is not excepting a logo to be there by default.

@bosd bosd mentioned this pull request Oct 18, 2025
Open
@jguenat
Copy link
Member

jguenat commented Oct 20, 2025

Hi @bosd

I checked on my side and removed the default image for the logo to fix the tests in partner_brand.
I don't really see the value of this default logo.?

Also I detected some issues.

  • rendering Boxed and Bold template caused a traceback in the wizard.
  • The brand colors where not applied on documents. This modules dynamically creates an asset for the brand colors. You need to keep it in the manifest even if it seems useless at first glance.

I did the modifications there jguenat#5

Feel free to chery-pick/fixup what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yvaucher yvaucher yvaucher approved these changes

+2 more reviewers

@astirpe astirpe astirpe approved these changes

@marielejeune marielejeune marielejeune approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved migration needs review

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.