[15.0] [FIX+IMP] pos_event_sale: compatibility with pos certification modules
#962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When paying a `pos.order`, confirm only the `event.registration` that are in draft state. Don't attempt to confirm the ones that are already confirmed, nor the ones that might be cancelled.
If we cancel a `pos.order`, we should cancel the related `event.registration`(s) However, if the `event.registration` is already done, we should not cancel it as it would be already too late to do so.
Registrations created from the PoS are not to be confirmed automatically. We confirm them when the `pos.order` is paid, but they are to remain in `draft` until then.
99f0ca3 to
e59deae
Compare
In the PoS, if the order is not paid, then it's not confirmed. If it's not confirmed, then we might as well ignore it. We shouldn't cancel any existing registrations until then.
Negated lines are particularly useful with PoS modules that disable the removal of pos orderlines through the use of ``disallowLineQuantityChange``. This is the case of `l10n_fr_pos_cert` module, for example. But there are other core modules doing it, too. In this case, added order lines can't be removed. Instead, the cashier is encouraged to add a negative to 'cancel' the original one. e.g.: Adds a line with 10 tickets. Then, adds a line with -10 tickets. This should be almost the same as removing the first line: no actual registration should be confirmed in the end, as we're reverting this sale.
e59deae to
8723b3f
Compare
Moved some ORM tests to `tests_backend`, that will execute faster than tours. Added unit tests to cover more backend scenarios.
e04ab31 to
097acf2
Compare
|
@ivantodorovich thanks for the great and necessary improvement 👍 |
yankinmax
approved these changes
Apr 6, 2023
|
/ocabot merge major |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 82d85ae. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negated lines are particularly useful with PoS modules that disable the removal
of pos orderlines through the use of
disallowLineQuantityChange.This is the case of
l10n_fr_pos_certmodule, for example. But there are othercore modules doing it, too.
In this case, added order lines can't be removed. Instead, the cashier is
encouraged to add a negative to 'cancel' the original one.
e.g.:
Adds a line with 10 tickets.
Then, adds a line with -10 tickets.
This should be almost the same as removing the first line: no actual
registration should be confirmed in the end, as we're reverting this sale.
Easier to review commit by commit