-
-
Notifications
You must be signed in to change notification settings - Fork 659
[16.0] [MIG] pos_cash_move_reason #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
[16.0] [MIG] pos_cash_move_reason #1068
Conversation
[REF] factor code [UPD] fr translation and pot file
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
[REF] Don't use ``product.product`` model for Reasons, because Odoo remove the fields ``expense_pdt`` ``and income_pdt`` from the model. Use instead a new model ``pos.move.reason`` for this purpose. [REF] Doesn't inherit from ``cash.box.in`` and ``cash.box.out`` model, as there are bad designed and doesn't allow clean inheritance. Instead, use new transient model ``wizard.pos.move.reason``. [REF] Oca convention. add readme folder.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/
Currently translated at 100.0% (38 of 38 strings) Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/
…e context timezone
Currently translated at 100.0% (38 of 38 strings) Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/fr_CH/
Currently translated at 7.9% (3 of 38 strings) Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-15.0/pos-15.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/
Currently translated at 100.0% (38 of 38 strings) Translation: pos-15.0/pos-15.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/it/
Currently translated at 100.0% (38 of 38 strings) Translation: pos-15.0/pos-15.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/it/
Currently translated at 100.0% (38 of 38 strings) Translation: pos-15.0/pos-15.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/it/
Currently translated at 97.3% (37 of 38 strings) Translation: pos-15.0/pos-15.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/ca/
Currently translated at 100.0% (38 of 38 strings) Translation: pos-15.0/pos-15.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/es/
5af2b9d to
23048a8
Compare
23048a8 to
baa8065
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for migrating this module !
Diff code review ✔️
Tested locally and it works as expected on other versio ✔️
I was surprised that the original button "Cash in / Cash out" was still there but it seems to be accepted in others versions too.
Could you check my little PR here AntoniRomera#1 that improve Cash reason Form view :)
OCB test failed also :)
Thanks !
|
ping @AntoniRomera, are you still working on this PR ? |
|
No, and right now I don't have time, you can make a PR and I'll close this one. |
|
@AntoniRomera my PR is ready, you can close this one thank youu :) |
No description provided.