[19.0][MIG] session_db #3413
Open
[19.0][MIG] session_db #3413
+915
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream FilesystemSessionStore does not do that.
Retry on OperationalError exception, which we receive on database restart. Return cursor to pool when reconnecting.
There were concurrency issues in evented mode. So while I was at it, I added support for threaded mode too.
If the connection to the database fails when retrying a session operation, we end up with no cursore, which makes subsequent session operations fail. We fix this by ensuring we have cursor before any operations.
…gument 'max_lifetime'" when autovacuum gets executed. Signed-off-by: Christoph Fiehe <[email protected]>
It has been implemented.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-session_db Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-session_db/
with the parameter "login" in `_make_postgres_uri()` it becomes impossible to log in with the configured database, as it has to have the name "user". This is because of passing the `connection_info` dict as keywords parameter into the function. But because `connection_info_for` called in `setUp()` reads the config file of odoo and there the database user is `db_user` the keyword parameter is discarded and `login` is not set. The `db_`-prefix is removed. So user and password are not applied to the uri/dsn and thus login to the database is not possible, if the database wants those parameters. When I applied this change in our internal CI of solute.de, everything worked fine afterwards. This has to be ported to 17.0 and 18.0 as well.
0be1123 to
b53d0a0
Compare
sbidoul
commented
Oct 14, 2025
| "did you pass in a string instead of a list?" | ||
| ) | ||
| self._cr.execute( | ||
| "DELETE FROM http_sessions WHERE sid LIKE %s||'%%'", (identifier,) |
There was a problem hiding this comment.
This would not be correct if identifier can contain a % but I don't think that is possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.