Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kba
Copy link
Member

@kba kba commented Oct 9, 2020

No description provided.

@kba kba requested a review from bertsky October 9, 2020 11:51
Copy link
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am just seeing this now: We actually have to rewrite the whole function. Up above, we filter by MIME type alone. So whenever (for some list of pageIds) there is even a single page with PAGE annotation, only that page survives.

What we need instead:

  • find_all_files filtering MIME for PAGE or image/*
  • aggregate results by page ID, and iterate:
  • if the page has a PAGE hit, keep only that
  • else if it has a single hit, keep it
  • else raise

@bertsky
Copy link
Collaborator

bertsky commented Nov 5, 2020

Superseded by #635

@bertsky bertsky closed this Nov 5, 2020
@kba kba deleted the fix-622 branch November 16, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants