Logging test fix #679
Merged
Logging test fix #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests behaved strangely when a
$HOME/ocrd_logging.confwas present. Most of the errors result from different configuration, hence thestring in processor-outputtests fail, which is to be expected. However, there were issues related to theos.chdircall insetUpClassintests/base.py. Moving this tosetUpand ensuring that all tests callsuper().setUpin their ownsetUp(where applicable) fixes this.Also contains a few improvements to the comments in the bundled
ocrd_logging.confby @bertsky.We should probably create an ocrd_logging.conf that is equivalent to the builtin config and run the unit tests once without
ocrd_logging.confand once with.