No more pkg_resources #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and move ocrd-tool.json to a importlib findable place
kba
approved these changes
Jun 24, 2022
Member
kba
left a comment
There was a problem hiding this comment.
Even if performance gain is yet to be proven, I see no reason why it would degrade performance either, so LGTM, thanks for following up on the discussion.
Contributor
Author
|
I just removed the WIP label, as the implementation is finished. The performance improvement is neglible, as far as I could interpret the profiler, the startup time is spent mostly on importing modules, and I have no clue how to improve on that. |
This was referenced Jun 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first attempt to get rid of pkg_resources as mentioned in #881
I did not measure anything yet, and subjectively not much changed, but we'll see.