Thanks to visit codestin.com
Credit goes to github.com

Skip to content

resmgr: insert from tool instead of append #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kba merged 1 commit into from
Jan 20, 2023
Merged

resmgr: insert from tool instead of append #971

kba merged 1 commit into from
Jan 20, 2023

Conversation

@bertsky
Copy link
Collaborator

@bertsky bertsky commented Jan 15, 2023

(otherwise dedup will stick to the existing entries)

@bertsky
resmgr: insert from tool instead of append
39c53fc 
(otherwise dedup will stick to the existing entries)
@bertsky bertsky requested a review from kba January 15, 2023 01:23
@bertsky
Copy link
Collaborator Author

bertsky commented Jan 15, 2023

CI failure: only macos (unrelated)

@bertsky
Copy link
Collaborator Author

bertsky commented Jan 16, 2023

(otherwise dedup will stick to the existing entries)

to the relevance of this: ocrd resmgr download -o ... does not work without it

kba
kba approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@kba kba merged commit 39c53fc into master Jan 20, 2023
@bertsky bertsky deleted the resmgr-dynamic-dedup-to-new branch February 6, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kba kba kba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bertsky @kba