Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WorkspaceValidator mets_files: allow files without pageId #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kba merged 3 commits into from
Feb 12, 2023
Merged

WorkspaceValidator mets_files: allow files without pageId #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
122f807
WorkspaceValidator mets_files: allow files without pageId
bertsky Feb 8, 2023
376c1de
skip test_validate_files_nopageid
bertsky Feb 8, 2023
ab3cb13
forgot import
bertsky Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ocrd_validators/ocrd_validators/workspace_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,6 @@ def _validate_mets_files(self):
for f in self.mets.find_files():
if f._el.get('GROUPID'): # pylint: disable=protected-access
self.report.add_notice("File '%s' has GROUPID attribute - document might need an update" % f.ID)
if not f.pageId:
self.report.add_error("File '%s' does not manifest any physical page." % f.ID)
if not f.url:
self.report.add_error("File '%s' has no mets:Flocat/@xlink:href" % f.ID)
continue
Expand Down
2 changes: 2 additions & 0 deletions tests/validator/test_workspace_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from pathlib import Path
from os.path import join
from shutil import copytree
import pytest

from ocrd_utils import pushd_popd
from ocrd.resolver import Resolver
Expand Down Expand Up @@ -116,6 +117,7 @@ def test_validate_file_groups_bad_name(self):
self.assertIn("Invalid USE name 'X' in fileGrp", report.notices[0])
self.assertIn('No files', report.errors[0])

@pytest.mark.skip(reason="missing pageId means document-global now")
def test_validate_files_nopageid(self):
with TemporaryDirectory() as tempdir:
workspace = self.resolver.workspace_from_nothing(directory=tempdir)
Expand Down